Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Account and Volume Mounts Post-Deployment Split #171

Open
eugene-davis opened this issue Jun 8, 2023 · 2 comments
Open

Service Account and Volume Mounts Post-Deployment Split #171

eugene-davis opened this issue Jun 8, 2023 · 2 comments

Comments

@eugene-davis
Copy link
Contributor

I ran into a slight issue that happened since the helm chart split the worker and server deployment.
The worker will now happily generate a service account (via a non-configurable name), but the server deployment will use default. When combined with the volume configuration applying on both deployments, if you are using csi secret store to load in secrets from HashiCorp Vault there are SA's that need access where there used to be just one.

The most straight-forward way to fix this would probably be to just have the worker and server use the same service account once it is created, but for max-security deployments it might make more sense to make both the SAs and the volumes + volumeMounts individually configurable.

@eugene-davis
Copy link
Contributor Author

If I find time (which might be a while) I can try to add this, but since I see at least a couple of ways to approach it I didn't want to just drop in a PR.

@BeryJu
Copy link
Member

BeryJu commented Jun 8, 2023

This is indeed currently the case for security, since the worker is the only deployment actually accessing the K8s api and the server container doesn't need it.

We could add a separate SA for the server deployment and not bind and roles to it, which would allow people to bind custom roles to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants