Skip to content
This repository has been archived by the owner on Jul 22, 2019. It is now read-only.

Please update github.com/gobuffalo/release dependency #18

Closed
matthijskooijman opened this issue Apr 15, 2019 · 1 comment
Closed

Please update github.com/gobuffalo/release dependency #18

matthijskooijman opened this issue Apr 15, 2019 · 1 comment

Comments

@matthijskooijman
Copy link

The go.mod file still refers to an older version, which pulls in an older version of golang.org/x/tools which ends up breaking upgrades due to a go-diff rename. AFAIU this is something that should be fixed in go, but until it is, it can be worked around by not having any (indirect) references to renamed or otherwise problematic packages.

Updating the github.com/gobuffalo/release dependency to the latest version should fix (part of) this problem.

To reproduce the problem, try:

(This uses gotip for a clearer error message, but it also happens with regular go 1.11 or 1.12).

matthijs@grubby:~/bar$ gotip mod init bar
go: creating new go.mod: module bar
matthijs@grubby:~/bar$ gotip get -d github.com/gobuffalo/buffalo-plugins
[snip output]
matthijs@grubby:~/bar$ gotip get -u -m
[snip output]
go get: github.com/gobuffalo/release@v1.2.5 ->
        github.com/gobuffalo/genny@v0.0.0-20190219203444-c95082806342 ->
        github.com/gobuffalo/gogen@v0.0.0-20190219194924-d32a17ad9761 ->
        golang.org/x/tools@v0.0.0-20190219185102-9394956cfdc5 ->
        cloud.google.com/go@v0.36.0 ->
        golang.org/x/build@v0.0.0-20190111050920-041ab4dc3f9d ->
        sourcegraph.com/sourcegraph/go-diff@v0.5.0 ->
        sourcegraph.com/sourcegraph/go-diff@v0.5.1: parsing go.mod: unexpected module path "github.com/sourcegraph/go-diff"
@matthijskooijman
Copy link
Author

Thanks for the superfast response, the new version seems to work.

I was tracing another broken dependency path, preparing to report it elsewhere, but it seems that was fixed by this commit as well (the path started with licensor plugin, which circled down into older versions of buffalo-plugins).

To apply this fix, I had to first explicitly upgrade buffalo-plugins using go get -u github.com/gobuffalo/buffalo-plugins, afterwards go get -u -m works as expected again.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant