Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks should be done with DOTALL #21

Open
sylvinus opened this issue Aug 28, 2017 · 0 comments
Open

Benchmarks should be done with DOTALL #21

sylvinus opened this issue Aug 28, 2017 · 0 comments

Comments

@sylvinus
Copy link

In the benchmark against the regexp package, the DOTALL regexp option should be used because without it .* is not the same as the glob * (regexp has to exclude \n). A \n separator for glob could also be used.

I suspect doing that will narrow the gap between glob and regexp but provide a fairer comparison.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant