Save calendar name reference in loaded calendar #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeSouthan
requested changes
Mar 4, 2021
lib/business/calendar.rb
Outdated
| working_days: data["working_days"], | ||
| extra_working_dates: data["extra_working_dates"], | ||
| calendar_name, | ||
| **data.slice("holidays", "working_days", "extra_working_days"), |
There was a problem hiding this comment.
I think we should convert initialize to take kwargs here and keep the explicit definition of the arguments.
Suggested change
| **data.slice("holidays", "working_days", "extra_working_days"), | |
| name: calendar_name, |
lib/business/calendar.rb
Outdated
|
|
||
| def initialize(config) | ||
| def initialize(name, config) |
There was a problem hiding this comment.
As above, let's convert this to have explicit nil kwargs, something along the lines of:
Suggested change
| def initialize(name, config) | |
| def initialize(name:, extra_working_dates: nil, working_days: nil, holidays: nil) |
|
@JoeSouthan Thanks for the suggestion! That is better. I've updated the PR to reflect those nil kwargs. |
JoeSouthan
approved these changes
Mar 4, 2021
|
Released as v2.2.0 |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Business::Calendar at Modern Treasury.
There are a few use cases where we point a bank interface on a calendar based on several config values. It's helpful for us to sometimes print out the loaded configuration, including the calendar reference. I thought it would be helpful to have a
.namereference on the calendar instance.