Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: CoBlocks site design conflict #856

Closed
AnthonyLedesma opened this issue Apr 6, 2023 · 2 comments
Closed

FSE: CoBlocks site design conflict #856

AnthonyLedesma opened this issue Apr 6, 2023 · 2 comments
Assignees

Comments

@AnthonyLedesma
Copy link
Member

Fatal error: Uncaught Error: Call to undefined function Go\Core\get_design_style() in /var/www/html/wp-content/plugins/coblocks/includes/class-coblocks-site-design.php:126 Stack trace: #0 /var/www/html/wp-content/plugins/coblocks/includes/class-coblocks-site-design.php(424): CoBlocks_Site_Design::get_coblocks_site_design_data() #1 /var/www/html/wp-includes/class-wp-hook.php(308): CoBlocks_Site_Design->editor_assets('') #2 /var/www/html/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters(NULL, Array) #3 /var/www/html/wp-includes/plugin.php(517): WP_Hook->do_action(Array) #4 /var/www/html/wp-admin/site-editor.php(156): do_action('enqueue_block_e...') #5 {main} thrown in /var/www/html/wp-content/plugins/coblocks/includes/class-coblocks-site-design.php on line 126

The call to the get_design_style function in CoBlocks seems to be crashing.

@jrtashjian
Copy link
Member

Good callout. This is something we realized we would lose in the transition since FSE handles it all now. We could possibly conditionally load it in CoBlocks by detecting the active version of Go on a site. So less than v2 would load it, v2 or greater would not.

@jrtashjian
Copy link
Member

Created a new issue in CoBlocks for tracking, and also Jira for internal tracking.

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants