Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete map keys #12

Open
scommisso opened this issue Jun 8, 2017 · 1 comment
Open

Delete map keys #12

scommisso opened this issue Jun 8, 2017 · 1 comment

Comments

@scommisso
Copy link
Contributor

scommisso commented Jun 8, 2017

Either #update() needs to support deleting map keys (maybe triggered by null values?), or #remove() semantics need to be updated to support deleting map keys.

Since we already have validation that #update() cannot set map keys to null, I propose that null values in here will generate a DELETE <mapFieldName>["<mapNullPropName>"] FROM <entityName> WHERE <conditionals> statement.

Right now, to "delete" a map key, we are required to set it to some sort of empty value. This is fine for most maps, but causes problems with a map<text, JSON>.

@jcrugzz
Copy link
Collaborator

jcrugzz commented Apr 17, 2018

@scommisso want to take a stab at this one when you have the bandwidth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants