fix(updating): use PUT not PATCH when updating an existing Secret (#20)

PATCH is going to result in a merge, potentially resulting in a union of the previous Secret's fields and the updated Secret's fields.
external-secrets · Feb 20, 2019 · 856d8e0 · 856d8e0
1 parent 183e280
commit 856d8e0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/poller.js b/lib/poller.js
@@ -98,7 +98,7 @@ class Poller {
     }
 
     this._logger.info(`updating secret ${secretName}`);
-    return kubeNamespace.secrets(secretName).patch({ body: secretManifest });
+    return kubeNamespace.secrets(secretName).put({ body: secretManifest });
   }
 
   /**

diff --git a/lib/poller.test.js b/lib/poller.test.js
@@ -186,13 +186,13 @@ describe('Poller', () => {
 
     it('updates secret', async () => {
       kubeNamespaceMock.get = sinon.stub().resolves({ fakeSecretName: 'fakeSecretString' });
-      kubeNamespaceMock.patch = sinon.stub().resolves();
+      kubeNamespaceMock.put = sinon.stub().resolves();
 
       await poller._upsertKubernetesSecret(upsertSecretParams);
 
       expect(kubeNamespaceMock.secrets.calledWith('fakeSecretName')).to.be.true;
       expect(kubeNamespaceMock.get.called).to.be.true;
-      expect(kubeNamespaceMock.patch.calledWith({
+      expect(kubeNamespaceMock.put.calledWith({
         body: {
           apiVersion: 'v1',
           kind: 'Secret',
-Original file line number
+Diff line change
@@ Expand Up / @@ -98,7 +98,7 @@ class Poller { @@
         }
         this._logger.info(`updating secret ${secretName}`);
-        return kubeNamespace.secrets(secretName).patch({ body: secretManifest });
+        return kubeNamespace.secrets(secretName).put({ body: secretManifest });
       }
       /**
@@ Expand Down @@