Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching away from GitPython #66

Closed
tarkatronic opened this issue Aug 25, 2020 · 1 comment
Closed

Consider switching away from GitPython #66

tarkatronic opened this issue Aug 25, 2020 · 1 comment
Labels
design decision needed Maintainers must agree on a direction before this is worked on enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@tarkatronic
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe.

GitPython is "in maintenance mode", and has no active development or even active bugfixing. It does not play well with Windows. And it's actually mostly a wrapper around the git command line application. Which seems... strange.

Describe the solution you'd like

I would like to see us move away from using GitPython, with the hopes of adding first-class Windows support and improving some of the performance of this application.

Describe alternatives you've considered

One option is for us to take over maintenance of GitPython. Honestly, that's just not realistic. So let's scratch that one immediately.

A larger discussion around this can be found in the dvc project. A lot of good information on the topic can be found in that thread, along with two alternatives:

I am leaning toward dulwich at the moment. It's pure Python, and looks a little higher level than pygit2. In general I'm okay with low level APIs, but it seems to me that pygit2 is just a bit too low level/primitive. For example, this is how you clone a repo over SSH. I would rather not have to get that far into the weeds.

Teachability, Documentation, Adoption, Migration Strategy

This change should be transparent to the user, with the only changes being actual Windows support and hopefully improved performance.

@tarkatronic tarkatronic added enhancement New feature or request help wanted Extra attention is needed design decision needed Maintainers must agree on a direction before this is worked on labels Aug 25, 2020
@mxhenry-godaddy mxhenry-godaddy linked a pull request Oct 28, 2020 that will close this issue
@mxhenry-godaddy mxhenry-godaddy added this to the Version 2.1 milestone Nov 3, 2020
@tarkatronic tarkatronic modified the milestones: Version 2.1, Version 3.0 Nov 30, 2020
@rdrey rdrey mentioned this issue Dec 11, 2020
@tarkatronic
Copy link
Contributor Author

Fixed in #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design decision needed Maintainers must agree on a direction before this is worked on enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants