Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't submit icon url that ends in ?raw=true #314

Open
blackears opened this issue Dec 10, 2023 · 4 comments
Open

Can't submit icon url that ends in ?raw=true #314

blackears opened this issue Dec 10, 2023 · 4 comments

Comments

@blackears
Copy link

I'm trying to submit to the asset library using the Custom method. I need to provide a URL to an icon. I want to provide a link to one uploaded to my Github page, but it's being rejected because it ends in ?raw=true instead of .png. Could the code allow for an exception for this from github repositories?

Same for anything I might upload to google drive. They don't end in .png either.

Error: Due to spam problems, we have to reject your asset because:
"https://github.com/blackears/terrain_layered_shader/blob/master/godot/icon.png?raw=true" doesn't look correct; it should be similar to "http<s>://<url>.<png/jpg>". Make sure the icon URL is correct.
Please contact the community administrators if this is not spam.
@YuriSizov
Copy link
Contributor

YuriSizov commented Dec 11, 2023

GitHub repositories provide compatible links. In fact, the one that you've submitted is redirected to one:
https://raw.githubusercontent.com/blackears/terrain_layered_shader/master/godot/icon.png

(although it's preferable if you use one from a specific commit hash rather than from the master to avoid changing it unexpectedly for users).

@Calinou
Copy link
Member

Calinou commented Dec 13, 2023

We could perform the redirect on our end automatically (using a regex), so you don't have to do it yourself when submitting the asset.

@blackears
Copy link
Author

I know you're doing a redesign - it might be better in the new design for you to just host everything so you're not reliant on external sites.

But also, perhaps have your regex just ignore everything after the ? could work too.

@Skylarity
Copy link

Skylarity commented Aug 19, 2024

Hey folks - I'm bringing this thread back from the dead because as of the current version of GitHub's raw URLs, the Asset Library no longer allows the only form of raw URLs (https://github.com/<user>/<repo>/blob/<branch>/<filename>.(png|jpg|jpeg)?raw=true), blocking them as spam. The aforementioned redirect seemingly no longer works either.

I'm not in the loop about any sort of site redesign (if that happened already or not), but hopefully this change could be implemented soon regardless! If I have spare time I might cook up a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants