Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORTANT] godot-cpp commits to use to match official 4.4 beta releases #1689

Closed
dsnopek opened this issue Jan 20, 2025 · 8 comments
Closed
Labels
documentation topic:gdextension This relates to the new Godot 4 extension implementation
Milestone

Comments

@dsnopek
Copy link
Collaborator

dsnopek commented Jan 20, 2025

Like we did for previous Godot 4.x versions (with #874, #1136, #1267, and #1475), this pinned issue will be used to list the godot-cpp commits which are in sync with matching Godot 4.4 beta and RC snapshots.

To benefit from non-compat breaking changes to godot-cpp on an older snapshot, you might be able to get it to work by using godot-cpp master and syncing the contents of gdextension manually with the official snapshot you're using (i.e. dumping the extension API and GDExtension interface with godot --dump-extension-api --dump-gdextension-interface).

@dsnopek dsnopek added documentation topic:gdextension This relates to the new Godot 4 extension implementation labels Jan 20, 2025
@dsnopek dsnopek added this to the 4.4 milestone Jan 20, 2025
@dsnopek dsnopek pinned this issue Jan 20, 2025
@sash-rc
Copy link

sash-rc commented Jan 21, 2025

Unfortunately, godot.4.4-beta1 --dump-extension-api --dump-gdextension-interface on godot-cpp.4.3 doesn't compile, as it complains about missed type char32

@dsnopek
Copy link
Collaborator Author

dsnopek commented Jan 21, 2025

Unfortunately, godot.4.4-beta1 --dump-extension-api --dump-gdextension-interface on godot-cpp.4.3 doesn't compile, as it complains about missed type char32

The note at the bottom of the description is referring to doing the reverse: using godot-cpp master and dumping the extension API and interface from Godot v4.3 (or some other earlier stable release).

@sash-rc
Copy link

sash-rc commented Jan 21, 2025

The note at the bottom of the description is referring to doing the reverse

Oh ... sorry, didn't figured out, because to be honest, in my case, currently master is barely usable - without fixing #1610 it is way slow, not only when I build it, but also when I work (compile) an extension for my project.

@dsnopek
Copy link
Collaborator Author

dsnopek commented Jan 21, 2025

Ah, thanks for the reminder! That issue fell off my radar. I just reviewed and merged PR #1628 which should fix the compile time regression

@Klaim
Copy link
Contributor

Klaim commented Feb 24, 2025

Are there commits for beta4 and rc1?

@dsnopek
Copy link
Collaborator Author

dsnopek commented Feb 24, 2025

Are there commits for beta4 and rc1?

Sorry, I spaced on those!

I've just sync'd with rc1. At this point, I don't think it's worth doing beta4, given that the beta3 one should still work, and the goal of doing these sync's is to facilitate testing the current dev release and we've already moved on to rc1.

@Klaim
Copy link
Contributor

Klaim commented Feb 24, 2025

Noted, will sync with rc1 only 👍🏽

@dsnopek dsnopek unpinned this issue Mar 3, 2025
@dsnopek
Copy link
Collaborator Author

dsnopek commented Mar 3, 2025

Closing now that Godot 4.4-stable is released!

@dsnopek dsnopek closed this as completed Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Development

No branches or pull requests

3 participants