Apply suggestions from code review

Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: Tomasz Chabora <kobewi4e@gmail.com>

Author: 3 people

editor/inspector/editor_inspector.cpp

@@ -1758,11 +1758,11 @@ Size2 EditorInspectorCategory::get_minimum_size() const {
 	return ms;
 }
 
-void EditorInspectorCategory::_collect_properties(const Object *p_object, Vector<String> &p_properties) const {
+void EditorInspectorCategory::_collect_properties(const Object *p_object, LocalVector<String> &r_properties) const {
 	List<PropertyInfo> property_list;
 	p_object->get_property_list(&property_list, true);
 
-	String current_category = "";
+	String current_category;
 	for (const PropertyInfo &prop_info : property_list) {
 		if (prop_info.usage & PROPERTY_USAGE_GROUP) {
 			continue;
@@ -1778,7 +1778,7 @@ void EditorInspectorCategory::_collect_properties(const Object *p_object, Vector
 			continue;
 		}
 
-		p_properties.push_back(prop_info.name);
+		r_properties.push_back(prop_info.name);
 	}
 }
 
@@ -1787,11 +1787,11 @@ void EditorInspectorCategory::_handle_menu_option(int p_option) {
 		case MENU_COPY_VALUE: {
 			Object *object = EditorInterface::get_singleton()->get_inspector()->get_edited_object();
 			Dictionary clipboard;
-			Vector<String> properties;
+			LocalVector<String> properties;
 			_collect_properties(object, properties);
 
 			clipboard["path"] = doc_class_name;
-			for (String property_name : properties) {
+			for (const String &property_name : properties) {
 				clipboard[property_name] = object->get(property_name);
 			}
 			InspectorDock::get_inspector_singleton()->set_property_clipboard(clipboard);
@@ -1806,14 +1806,14 @@ void EditorInspectorCategory::_handle_menu_option(int p_option) {
 				break;
 			}
 
-			String action_name = "Set category " + category_name;
+			String action_name = vformat(TTR("Set category %s"), category_name);
 
 			EditorUndoRedoManager *undo_redo = EditorUndoRedoManager::get_singleton();
 			undo_redo->create_action(action_name);
 
-			for (String property_name : clipboard.keys()) {
-				Variant value = clipboard[property_name];
-				undo_redo->add_do_property(object, property_name, value);
+			for (const KeyValue<Variant, Variant> &pair : clipboard) {
+				String property_name = pair.key;
+				undo_redo->add_do_property(object, property_name, pair.value);
 				undo_redo->add_undo_property(object, property_name, object->get(property_name));
 			}
 
@@ -2533,13 +2533,13 @@ void EditorInspectorSection::_update_popup() {
 	menu->add_icon_shortcut(get_editor_theme_icon(SNAME("ActionPaste")), ED_GET_SHORTCUT("property_editor/paste_group_values"), MENU_PASTE_VALUE);
 }
 
-void EditorInspectorSection::_collect_properties(Vector<String> &p_properties) const {
+void EditorInspectorSection::_collect_properties(LocalVector<String> &r_properties) const {
 	List<PropertyInfo> property_list;
 	object->get_property_list(&property_list, true);
 
-	String current_category = "";
-	String current_group = "";
-	String current_subgroup = "";
+	String current_category;
+	String current_group;
+	String current_subgroup;
 	for (const PropertyInfo &prop_info : property_list) {
 		if (prop_info.usage & PROPERTY_USAGE_GROUP) {
 			current_group = prop_info.name;
@@ -2558,13 +2558,13 @@ void EditorInspectorSection::_collect_properties(Vector<String> &p_properties) c
 		if (!(prop_info.usage & PROPERTY_USAGE_EDITOR)) {
 			continue;
 		}
-		if (prop_info.name.split("/").size() > 1) {
-			current_group = prop_info.name.split("/")[0];
+		if (prop_info.name.get_slice_count("/") > 1) {
+			current_group = prop_info.name.get_slicec('/', 0);
 		}
 		if (!(current_category + "/" + current_group + "/" + current_subgroup).begins_with(get_inspector_path())) {
 			if (current_category.ends_with(".gd")) {
 				String section_path = inspector_path;
-				section_path = section_path.replace(section_path.split("/")[0] + "/", "");
+				section_path = section_path.replace(section_path.get_slicec('/', 0) + "/", "");
 				if (!(current_group + "/" + current_subgroup).begins_with(section_path)) {
 					continue;
 				}
@@ -2573,19 +2573,19 @@ void EditorInspectorSection::_collect_properties(Vector<String> &p_properties) c
 			}
 		}
 
-		p_properties.push_back(prop_info.name);
+		r_properties.push_back(prop_info.name);
 	}
 }
 
 void EditorInspectorSection::menu_option(int p_option) const {
 	switch (p_option) {
 		case MENU_COPY_VALUE: {
-			Vector<String> properties;
+			LocalVector<String> properties;
 			Dictionary clipboard;
 			_collect_properties(properties);
 
 			clipboard["path"] = get_inspector_path();
-			for (String property_name : properties) {
+			for (const String &property_name : properties) {
 				clipboard[property_name] = object->get(property_name);
 			}
 			InspectorDock::get_inspector_singleton()->set_property_clipboard(clipboard);
@@ -2598,15 +2598,15 @@ void EditorInspectorSection::menu_option(int p_option) const {
 				break;
 			}
 
-			Vector<String> properties;
+			LocalVector<String> properties;
 			String action_name = "Set group " + group_name;
 
 			_collect_properties(properties);
 
 			EditorUndoRedoManager *undo_redo = EditorUndoRedoManager::get_singleton();
 			undo_redo->create_action(action_name);
 
-			for (String property_name : properties) {
+			for (const String &property_name : properties) {
 				Variant value = clipboard[property_name];
 				undo_redo->add_do_property(object, property_name, value);
 				undo_redo->add_undo_property(object, property_name, object->get(property_name));

editor/inspector/editor_inspector.h

@@ -352,7 +352,7 @@ class EditorInspectorCategory : public Control {
 	bool is_favorite = false;
 	bool menu_icon_dirty = true;
 
-	void _collect_properties(const Object *p_object, Vector<String> &p_properties) const;
+	void _collect_properties(const Object *p_object, LocalVector<String> &r_properties) const;
 	void _handle_menu_option(int p_option);
 	void _popup_context_menu(const Point2i &p_position);
 	void _update_icon();
@@ -489,7 +489,7 @@ class EditorInspectorSection : public Container {
 	void update_property();
 
 	void _update_popup();
-	void _collect_properties(Vector<String> &p_properties) const;
+	void _collect_properties(LocalVector<String> &r_properties) const;
 	void menu_option(int p_option) const;
 
 	EditorInspectorSection();