Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling problems on Android #11387

Closed
endragor opened this issue Sep 18, 2017 · 14 comments
Closed

Scaling problems on Android #11387

endragor opened this issue Sep 18, 2017 · 14 comments

Comments

@endragor
Copy link
Contributor

endragor commented Sep 18, 2017

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Godot bc005a5, Samsung Galaxy S6 (Android 7.0)

Issue description:

See how scaled screen looks like on Android (bad) vs macOS (ok) with the same project.

Android (bad)
macOS (ok)

Steps to reproduce:

git clone -b 2d-scale-bug https://github.com/endragor/etc2bug.git 2d-scale-bug
cd 2d-scale-bug
godot --export-debug Android test.apk

Then install and open test.apk on the device.

@volzhs
Copy link
Contributor

volzhs commented Sep 18, 2017

you can attach images directly on github with D&D.

@endragor
Copy link
Contributor Author

@volzhs thanks, will do that next time. Are the images still visible for you? Shouldn't this issue be put on 3.0 milestone? This seems to be the main thing preventing games from looking as expected on Android. There are also font scaling problems in general - it looks as if texts are scaled after being rasterized which results in severe visual artifacts.

@akien-mga akien-mga added this to the 3.0 milestone Sep 25, 2017
@Calinou
Copy link
Member

Calinou commented Sep 25, 2017

Are the images still visible for you?

Yes, the images are still visible. However, to my knowledge, Imgur deletes images which have received no views in 6 months and compresses large images (which may be undesirable in some cases). So, it's better to use GitHub attachments.

@endragor
Copy link
Contributor Author

Changed links to point to GitHub attachments.

@volzhs
Copy link
Contributor

volzhs commented Sep 25, 2017

I edited OP to show image directly.

@kosz78
Copy link
Contributor

kosz78 commented Oct 3, 2017

Some additional information.

Below some artifacts that taken from Android Device Monitor:
result screen(cropped):
screen_cr

Generated font texture (inverted for preview):
texture_neg

Texture parameters:
texture_params

Fragment shader that draw one symbol:
fragment_shader.txt

@endragor
Copy link
Contributor Author

Scaling part of this issue would be fixed by #12022. But even when scaling is alright, fonts and some other 2D elements are rendered ugly as shown in the previous comment.

@reduz
Copy link
Member

reduz commented Nov 9, 2017

Scaling should now be fixed. I don't undestand the font problem

@endragor
Copy link
Contributor Author

Texts get distorted on Android (and iOS). Take a look at these images:

Android (bad)

(it may not be seen in the preview easily - just open it in full size in a separate tab).

img

@endragor
Copy link
Contributor Author

Still seeing the scaling issue as shown on the original screenshot with current master.

@endragor
Copy link
Contributor Author

Now it's actually fine. So either I used old apk or old Godot or it's been fixed since the last comment :/

@reduz any chance you can look into the rendering issue? It's currently the main thing hurting the look on mobile. Seems to affect not only the fonts but any 2D elements. Very visible on the edges of UI elements.

@reduz
Copy link
Member

reduz commented Nov 22, 2017

@endragor the font problem is really strange, does it only happen on Android?

@endragor
Copy link
Contributor Author

@reduz both Android and iOS.

@akien-mga
Copy link
Member

The scaling issue being fixed, and the rendering issue tracked in #15116, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants