Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor previewing in SpatialEditor to allow non-camera objects #12083

Closed
dodgyville opened this issue Oct 14, 2017 · 6 comments
Closed

Refactor previewing in SpatialEditor to allow non-camera objects #12083

dodgyville opened this issue Oct 14, 2017 · 6 comments

Comments

@dodgyville
Copy link

Operating system or device, Godot version, GPU Model and driver (if graphics related):
all platforms, godot3.0

Issue description:
It would be useful for any 3D object with a pov (eg Camera, DirectionalLight) if the "preview" button was available in the viewport when that object is selected.

Currently when selecting a Camera a "preview" button appears in the viewport, selecting the button changes the view to that of the Camera, allowing game devs to see what the Camera is seeing.

This functionality would also be very useful for Directional Lights and I assume other objects with a directional element.

At the moment the existing functionality lives in SpatialEditorViewport and SpatialEditor but it is tied to a Camera reference being passed in from CameraEditorPlugin. It would require a small refactor to either become Object independent or to duplicate some functionality for DirectionalLight.

It would really improve workflow.

A similarly useful improvement to this workflow functionality is in #9135, allow the object being previewed in the viewport to be aligned to the viewport.

@ghost
Copy link

ghost commented Oct 14, 2017

Have you tried 'Align selection with view'?

@dodgyville
Copy link
Author

That's very useful, thanks! The editor could still really use a free roam camera/light mode.

@Calinou
Copy link
Member

Calinou commented Dec 24, 2019

I'll close this as the aforementioned features (align transform to view, freelook) are implemented since Godot 3.0.

@Calinou Calinou closed this as completed Dec 24, 2019
@Calinou Calinou added this to the 3.0 milestone Dec 24, 2019
@dodgyville
Copy link
Author

dodgyville commented Dec 24, 2019

Yeah, no, this functionality has not been added:

@Calinou
Copy link
Member

Calinou commented Dec 24, 2019

@dodgyville Let's consider the remaining points as a duplicate of #9550 then 🙂

Also, please be mindful of our code of conduct when replying.

@dodgyville
Copy link
Author

Sure, as long as you are mindful too please. Closing the ticket without consensus is a bit eyebrow raising...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants