Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the lightmap render result affected by the WorldEnvironment. #16398

Closed
leiget opened this issue Feb 4, 2018 · 6 comments
Closed

Make the lightmap render result affected by the WorldEnvironment. #16398

leiget opened this issue Feb 4, 2018 · 6 comments

Comments

@leiget
Copy link

leiget commented Feb 4, 2018

I suggest the environment map should affect the result of the Lightmapper.

Godot version:
ea99b90

OS/device including version:
Doesn't matter.

Issue description:
The WorldEnvironment doesn't affect the render result of the BakedLightmap.
envaffect

@ghost ghost added this to the 3.1 milestone Feb 5, 2018
@reduz reduz modified the milestones: 3.1, 3.2 Sep 6, 2018
@reduz
Copy link
Member

reduz commented Sep 6, 2018

This will be fixed in 3.2 when the lightmapper is re-made:

@leiget
Copy link
Author

leiget commented Sep 6, 2018

Cool, thanks. Thanks for the cool engine.

@aaronfranke
Copy link
Member

Has the lightmapper been remade in 3.2? I thought rendering changes will be done for 4.0?

@KoBeWi
Copy link
Member

KoBeWi commented Nov 22, 2020

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?

If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.

@Calinou
Copy link
Member

Calinou commented Nov 22, 2020

This is still the case in 3.2.3 – the lightmapper doesn't take the environment light into account. It will be fixed by #40035 once it's merged.

@JFonS
Copy link
Contributor

JFonS commented Jan 22, 2021

Closing as fixed by #44628

@JFonS JFonS closed this as completed Jan 22, 2021
@akien-mga akien-mga modified the milestones: 4.0, 3.2 Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants