Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the zoom buttons on graph editors #16488

Closed
Tracked by #19806
alpinus4 opened this issue Feb 8, 2018 · 10 comments
Closed
Tracked by #19806

Improve the zoom buttons on graph editors #16488

alpinus4 opened this issue Feb 8, 2018 · 10 comments

Comments

@alpinus4
Copy link

alpinus4 commented Feb 8, 2018

I'm supposed that this:


should show actual zoom level.

But with any zoom it ever shows "1".


Steps to reproduce:
Create any visual script and try to zoom.

Godot version:
v3.0.stable.official.mono

OS:
Windows 10 ver. 1709 64-bit

@groud
Copy link
Member

groud commented Feb 8, 2018

It's not the zoom level, it's the "reset to 1/1 scale" button.

@alpinus4
Copy link
Author

alpinus4 commented Feb 8, 2018

@groud Hah.. So it's a bit non-intuitive.

For ex. in photoshop reset zoom scale button looks like this:

And everyone know what it does.

I propose to add something like:

or:

@groud
Copy link
Member

groud commented Feb 8, 2018

Ok I guess something like than would make sense.

@groud groud reopened this Feb 8, 2018
@groud groud changed the title Visual scripting - incorrect zoom ratio. Improve the zoom buttons on graph editors Feb 8, 2018
@groud groud added enhancement and removed archived labels Feb 8, 2018
@bojidar-bg
Copy link
Contributor

IMO, it should be "reset", since "100%" is even more likely to be misinterpreted 😃

@fracteed
Copy link

I would really love to see smaller increments for the zoom levels with the +- buttons. I use a Wacom tablet almost exclusively and I find that I need to plug in a mouse just to use the wheel to get things zoomed to the level I need. Would be great to either have an editor option for the amount of zoom increment for those buttons, or better still just make them smaller by default(maybe 10 or 15 % increments).

@ghost
Copy link

ghost commented Feb 10, 2018

@fracteed just because you use a tablet for development (which is a rare use-case), doesn't mean we PC users (99% of developers) have to suffer with small icons.

@fracteed
Copy link

@girng I think you are confused...lol. You do know what a Wacom tablet (Intuos) is right? Pretty much every artist uses a Wacom to some extent. Maybe you think I meant a touchscreen PC, ala Surface Pro? Not sure what you mean by small icons, as I am referring to the zoom percentage you get each time the +- buttons are pressed.

@ghost
Copy link

ghost commented Feb 12, 2018

@fracteed well, to be fair you did say

"still just make them smaller by default(maybe 10 or 15 % increments)." i was thinking you are talking about the button img size. if not, i apologize.

"make them smaller" => "the buttons"

how does "make them" equate to one singular screen size percent, is where the confusion happened i think

@akien-mga
Copy link
Member

akien-mga commented Feb 13, 2018

@girng "them" is "zoom increments" in @fracteed's sentence. Smaller zoom increments (e.g. 10%) means that clicking + would go from 100% to 110%, instead of maybe 150% currently.

Please try to avoid the passive aggressiveness in your comments on what others propose though, it's not the first comment I read from you where you misinterpret something and call someone out. Always assume positive intent, and if you think that a proposal is not a good idea, phrase your objection respectfully and constructively.

@groud
Copy link
Member

groud commented Oct 7, 2019

This is implemented on master. Closing :)

@groud groud closed this as completed Oct 7, 2019
@akien-mga akien-mga added this to the 3.2 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants