Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree's "item_activated" and "item_double_clicked" signals #16839

Closed
YeldhamDev opened this issue Feb 20, 2018 · 5 comments · Fixed by #16861
Closed

Tree's "item_activated" and "item_double_clicked" signals #16839

YeldhamDev opened this issue Feb 20, 2018 · 5 comments · Fixed by #16861

Comments

@YeldhamDev
Copy link
Member

Godot version:
ad5ac05

Issue description:
According with the docs, item_activated is emitted when an item is double clicked. However, there is a signal named item_double_clicked which says it does exactly the same thing.

I tested both, and seems that only item_activated is emitted, so what's the point of the other signal?

@akien-mga
Copy link
Member

According to git blame it was added by @djrm in 70c9979, later modified by @volzhs.

@volzhs
Copy link
Contributor

volzhs commented Feb 20, 2018

based on commit, item_activated is emitted when double click on label,
and item_double_clicked is emitted when double click on icon.

@YeldhamDev
Copy link
Member Author

@volzhs I see. But neither the signal names or their descriptions even remotely imply that.

@volzhs
Copy link
Contributor

volzhs commented Feb 20, 2018

need someone to update docs I think.
but... it's not me, not a native speaker.

@akien-mga
Copy link
Member

akien-mga commented Feb 20, 2018

Maybe we should start maintaining a new list for the stuff we'd like to rename the day where we'll allow ourselves to break compatibility. Edit: Done, see #16863.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants