Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right docks move offscreen after switching to script tab #18078

Closed
Superwaitsum opened this issue Apr 9, 2018 · 8 comments
Closed

Right docks move offscreen after switching to script tab #18078

Superwaitsum opened this issue Apr 9, 2018 · 8 comments

Comments

@Superwaitsum
Copy link
Contributor

Godot version:

9e7cee2

OS/device including version:

Windows 8.1 x64
Screen Resolution: 1280x1024 (Maybe related?)

Issue description:
Switching to Script tab modifies the position of right side docks and can't be fixed until resizing
Similar to #17412, but with the script tab.

Steps to reproduce:
Have to use a build with #17923 merged (found it after bisecting).

Having the editor in fullscreen, switch to the Script tab, the Scene and inspector docks change their position, being off the screen.
This persist even after changing to 2D or 3D tabs, and only fixed after resizing the godot window while in those modes.

Minimal reproduction project:
An image showing it: (notice the right docks' displacement)
imagen

@akien-mga akien-mga added this to the 3.1 milestone Apr 9, 2018
@akien-mga
Copy link
Member

Have to use a build with #17923 merged (found it after bisecting).

You mean that it's a regression from #17923? CC @Paulb23

@Superwaitsum
Copy link
Contributor Author

Yes, found it testing commit by commit

@Paulb23
Copy link
Member

Paulb23 commented Apr 10, 2018

This is caused by the new drop down menu 'Syntax Highlighter' needing more space thus pushing the right side docks off the screen. I guess it could be shortened to just "Highlighter"? Or hiding it inside another sub menu?

@eon-s
Copy link
Contributor

eon-s commented Apr 11, 2018

In small resolution the whole right part is lost, it should respect the max size and shortening the word may not work.

@ghost
Copy link

ghost commented Apr 13, 2018

I am having the same problem too, tested it all on Godot 3 versions, (3.0.0 ~ 3.0.2); In my case I experience it when selecting a frame for an AnimatedSprite or just checking it or opening the lower part whereas the Debugging, etc can be found.

Yeah, resizing fixes the problem but if you open up the lower dock again it triggers it again.

Before
before

After
after

@Superwaitsum
Copy link
Contributor Author

After testing several editor languages, I can confirm that this bug isn't affecting the english editor, but translated versions of editor on master, since weblate translations are made with the 3.0 branch in mind and english can be considered a 'compact language' (don't know another way to describe it).

Tried to change "Syntax Highlighter" to "Highlighter" as @Paulb23 thought first , but it's not enough as @eon-s said.

Not sure how to handle this case:

  • Hiding it as @Paulb23 said.
  • Forgetting it until translation of 3.1 (which should have shorter phrases)?

Also, here are some possible solutions to avoid future bugs:

  • Suggest people that work UI on master to test another languages.
  • Adding editor translation guidelines. (Tell them shorter is better)
  • Opening a tracker bug like with HighDPI mode, but for the inverse case.

Sorry if this comment seems too bothersome.

@Paulb23
Copy link
Member

Paulb23 commented Jul 15, 2018

Guess this one can be closed now #19166 is merged?

@akien-mga
Copy link
Member

Fixed by #19166.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants