Custom node icons are not resized with higher display scaling values (doesn't apply to class_name-provided nodes)

[Calinou]

Godot version: Git f8417ac

OS/device including version: Fedora 28

Issue description: Custom nodes' icons will always be drawn at the default scale, even when using a larger editor scale. This occurs even when a SVG icon is used:

Steps to reproduce: Create or import a plugin that uses a PNG or SVG icon.

Minimal reproduction project: https://github.com/Calinou/godot-procedural-crosshair

[MatiasVME]

I can't see my icon directly, but I can see it in the add nodes part.

I'am using aeddb30

[Calinou]

@MatiasVME That's unrelated to the issue I'm reporting here.

[Calinou]

This doesn't seem to be fixed by #33019, as it only fixes the issue for custom types declared using class_name. Still, as custom types declared by editor plugins might be deprecated in the future, fixing this is low-priority.

[KoBeWi]

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?
(I tried changing my editor scale, but it doesn't seem to do anything...)

[Calinou]

I can't reproduce this issue with this project on Godot 3.2.3 and 3.2.4beta1:

The icons are displayed at the correct size but are still blurry, unfortunately. (They're SVGs with a reference size of 16×16 for correct display at 100% scaling.)

Zylann/godot_heightmap_plugin#209 says this can still be reproduced though…

[KoBeWi]

Ok I was just changing custom_display_scale instead of display_scale. I managed to reproduce the bug in 3.2.3:

(the original MRP also has this issue)

[coppolaemilio]

I have this same issue in my plugin, but it only happens on mac. It works well on windows.

(Notice the Dialogic icon at the top and the relative size on the rest of the icons) Even the custom nodes (the color bars) have icons that are shown smaller on mac.

Windows screenshot @125% display scale

Mac screenshot @any display scale:

[andrej-petrovic]

The icons are displayed at the correct size but are still blurry, unfortunately.

Calinou, were you able to fix the blurriness? Do you think it's related to this issue, or is it something separate?

Here is a screenshot of the problem. The bottom node is an actual StaticBody2D node, but the top node is a custom class where the icon is set to the StaticBody2D SVG copied to my project folder. Godot 3.5, Linux, editor scale set to 200% (for testing this out).

PNGs don't seem to have this problem, here the top node is using a 32x32 PNG of the icon exported via Inkscape:

[Calinou]

Calinou, were you able to fix the blurriness?

You can set the Svg > Scale import option to 2 in the Import dock for the editor icon. This will rasterize the image as 32×32 instead of 16×16.

[andrej-petrovic]

Thanks, that didn't work unfortunately, even tried to set the scale to 4 at one point, but it looks exactly the same. I had also tried fiddling with the Filter and Mipmaps flags but nothing seemed to make a difference.

It's not a big deal one way or another, was just curious if someone had already gone down this rabbit hole :D

[coppolaemilio]

There is a proposal to fix this kind of issues: godotengine/godot-proposals#5034

[dzil123]

This appears to be fixed in the crosshair project when the icon.svg has enabled "Scale With Editor Scale" from #64938, should this be closed?