Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge H and V BoxContainer functionality into ListContainer #28779

Closed
TheDuriel opened this issue May 9, 2019 · 5 comments
Closed

Merge H and V BoxContainer functionality into ListContainer #28779

TheDuriel opened this issue May 9, 2019 · 5 comments

Comments

@TheDuriel
Copy link
Contributor

Currently we have two nodes providing identical functionality for sorting control nodes in a list. H and Y BoxContainer respectively. Both extend BoxContainer.

The idea would be to take the opportunity for breaking changes in 4.0, and merge both of these nodes into one: ListContainer. With a simple bool to flip between H and Y.

This would also allow for swapping the behavior on the fly, which could be pretty cool.

@Jummit
Copy link
Contributor

Jummit commented May 9, 2019

Is it just me, or are HBoxContainer and VBoxContainer extremely easy to mix up? I always end up adding for the wrong node. This would add another step to making a HBoxContainer, but that isn't that bad.

@volzhs
Copy link
Contributor

volzhs commented May 9, 2019

current HBox and VBox are easily distinguishable in scene tree dock by its node icon.

@KoBeWi
Copy link
Member

KoBeWi commented May 20, 2019

IMO there's no need to change the name. BoxContainer is fine, as that's how it's called in other GUIs (or at least in Java).

@Calinou
Copy link
Member

Calinou commented Sep 1, 2021

Merging both classes together would make #36040 easier to implement, but reduz was against it last time I asked.

@KoBeWi
Copy link
Member

KoBeWi commented Nov 17, 2021

Closing the issue in favor of this proposal, which covers it: godotengine/godot-proposals#3558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants