Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The bookmark circle isn't drawn correctly. #32735

Closed
CowThing opened this issue Oct 11, 2019 · 5 comments · Fixed by #40973
Closed

The bookmark circle isn't drawn correctly. #32735

CowThing opened this issue Oct 11, 2019 · 5 comments · Fixed by #40973

Comments

@CowThing
Copy link
Contributor

Godot version:
3.2 alpha 1

OS/device including version:
Windows 10 64bit

Issue description:
The bookmark circle's pixels are not correct, the right and left sides are not even. I guess this is an issue with the draw_circle function. It might be better if this circle is replaced with a texture so that it can be drawn nicely and have anti-aliasing. Here is a scaled up screenshot for reference.

bookmark

@akien-mga
Copy link
Member

CC @Calinou @Paulb23

@Calinou
Copy link
Member

Calinou commented Oct 11, 2019

It makes sense to use an icon for bookmarks indeed, so that it can be antialiased.

@KoBeWi
Copy link
Member

KoBeWi commented Oct 11, 2019

I considered this icon at the original PR: https://github.com/alefragnani/vscode-bookmarks/blob/master/images/bookmark.svg

It's free to use AFAIK.

@Paulb23
Copy link
Member

Paulb23 commented Oct 11, 2019

Yeah, breakpoints should become a large circle icon, with a banner icon similar to the one that @KoBeWi linked for bookmarks.

@CowThing
Copy link
Contributor Author

I do like that bookmark icon. And making breakpoints large circles would help them stand out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants