-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon zipped with windows 10 unable to load because of required ZIP version #34626
Comments
I can confirm this on commit 318c693. It appears this is due to Windows-created ZIPs requiring a newer version to be extracted. This is likely a bug in the ZIP library we're using. test.zip: Zip archive data, at least v2.0 to extract
godot-modifiers-plugin-4e88b9812c26d35673d6c12198aeb2f8cb2d9425.zip: Zip archive data, at least v1.0 to extract
# Extract `test.zip`, create another one using `zip -r9 test-v1.zip test`
test-v1.zip: Zip archive data, at least v1.0 to extract
|
Still valid in 3.2.4 beta3 |
Still an issue in 3.5.1 |
This likely affects projects using ZIPReader now that #65281 was merged in 4.0.beta. |
I saw this while browsing github issues. https://github.com/zlib-ng/minizip-ng Might be a better maintained fork of the minizip. Might be worth checking if it supports the bug issue. |
Godot version:
Godot_v3.1.1-stable_win64
OS/device including version:
WIn10
Issue description:
editor/editor_asset_installer.cpp:175 - Condition ' !dir_map.has(ppath) ' is true. Continuing..:
Steps to reproduce:
Minimal reproduction project:
test.zip
Related Issue: the imported addon will be added to the root project folder
https://godotengine.org/asset-library/asset/457
https://github.com/samdze/godot-modifiers-plugin/archive/4e88b9812c26d35673d6c12198aeb2f8cb2d9425.zip
The text was updated successfully, but these errors were encountered: