Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon zipped with windows 10 unable to load because of required ZIP version #34626

Open
AlexHolly opened this issue Dec 27, 2019 · 5 comments
Open

Comments

@AlexHolly
Copy link
Contributor

AlexHolly commented Dec 27, 2019

Godot version:
Godot_v3.1.1-stable_win64

OS/device including version:
WIn10

Issue description:
editor/editor_asset_installer.cpp:175 - Condition ' !dir_map.has(ppath) ' is true. Continuing..:

Steps to reproduce:

  1. create addon
  2. use right click -> send to -> Compressed (zipped) folder
  3. AssetLib -> Import

Minimal reproduction project:
test.zip

Related Issue: the imported addon will be added to the root project folder

  1. download addon
    https://godotengine.org/asset-library/asset/457
    https://github.com/samdze/godot-modifiers-plugin/archive/4e88b9812c26d35673d6c12198aeb2f8cb2d9425.zip
  2. import addon
@Calinou
Copy link
Member

Calinou commented Dec 28, 2019

I can confirm this on commit 318c693.

It appears this is due to Windows-created ZIPs requiring a newer version to be extracted. This is likely a bug in the ZIP library we're using.

test.zip:                                                            Zip archive data, at least v2.0 to extract
godot-modifiers-plugin-4e88b9812c26d35673d6c12198aeb2f8cb2d9425.zip: Zip archive data, at least v1.0 to extract

# Extract `test.zip`, create another one using `zip -r9 test-v1.zip test`
test-v1.zip:                                                         Zip archive data, at least v1.0 to extract
$ zip --version
Copyright (c) 1990-2008 Info-ZIP - Type 'zip "-L"' for software license.
This is Zip 3.0 (July 5th 2008), by Info-ZIP.

test-v1.zip can be loaded successfully:

image

@KoBeWi
Copy link
Member

KoBeWi commented Nov 27, 2020

Still valid in 3.2.4 beta3

@patrickdown
Copy link
Contributor

Still an issue in 3.5.1

@Calinou
Copy link
Member

Calinou commented Dec 30, 2022

This likely affects projects using ZIPReader now that #65281 was merged in 4.0.beta.

@fire
Copy link
Member

fire commented Sep 28, 2024

I saw this while browsing github issues.

https://github.com/zlib-ng/minizip-ng Might be a better maintained fork of the minizip.

Might be worth checking if it supports the bug issue.

@fire fire changed the title unable to load addon (zipped with win10) Addon zipped with windows 10 unable to load because of required ZIP version Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants