Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project manager crash on master #36768

Closed
KoBeWi opened this issue Mar 3, 2020 · 5 comments · Fixed by #36855
Closed

Project manager crash on master #36768

KoBeWi opened this issue Mar 3, 2020 · 5 comments · Fixed by #36855

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Mar 3, 2020

Godot version:
2059528

Issue description:
When you run Godot, you get this error:

[0] ProjectList::set_order_option (x:\inne\godot\source\godot\editor\project_manager.cpp:1405)
[1] ProjectManager::_on_order_option_changed (x:\inne\godot\source\godot\editor\project_manager.cpp:2375)
[2] call_with_variant_args_helper<ProjectManager> (x:\inne\godot\source\godot\core\callable_method_pointer.h:139)
[3] call_with_variant_args<ProjectManager> (x:\inne\godot\source\godot\core\callable_method_pointer.h:161)
[4] CallableCustomMethodPointer<ProjectManager>::call (x:\inne\godot\source\godot\core\callable_method_pointer.h:177)
[5] Callable::call (x:\inne\godot\source\godot\core\callable.cpp:50)
[6] Object::emit_signal (x:\inne\godot\source\godot\core\object.cpp:1200)
[7] Object::emit_signal (x:\inne\godot\source\godot\core\object.cpp:1257)
[8] ProjectListFilter::_filter_option_selected (x:\inne\godot\source\godot\editor\project_manager.cpp:2743)
[9] ProjectListFilter::set_filter_option (x:\inne\godot\source\godot\editor\project_manager.cpp:2737)
[10] ProjectManager::ProjectManager (x:\inne\godot\source\godot\editor\project_manager.cpp:2503)
[11] Main::start (x:\inne\godot\source\godot\main\main.cpp:1931)
[12] widechar_main (x:\inne\godot\source\godot\platform\windows\godot_windows.cpp:160)
[13] _main (x:\inne\godot\source\godot\platform\windows\godot_windows.cpp:184)
[14] main (x:\inne\godot\source\godot\platform\windows\godot_windows.cpp:196)
[15] __scrt_common_main_seh (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
[16] BaseThreadInitThunk

Works if project is edited directly without opening Project Manager.

@akien-mga
Copy link
Member

akien-mga commented Mar 3, 2020

Probably from #36758 #36426.

@kuruk-mm
Copy link
Contributor

kuruk-mm commented Mar 4, 2020

I could not reproduce it from Ubuntu 16.04

What OS are you using? This happens when you open the Project Manager?

I tried, sorting the projects by name, last edit, etc.

@KoBeWi
Copy link
Member Author

KoBeWi commented Mar 4, 2020

I'm using Windows 10.

@akien-mga
Copy link
Member

I couldn't reproduce it initially, but I found out how to do it. You need to change the default project sorting option (which is saved in editor settings). It then crashes next time you open it.

@akien-mga
Copy link
Member

@kuruk-mm It's similar to #36613, the signal is fired too early after changing to callable_mp, and the callback method accesses a child node which is not in tree yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants