Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle2D emitting settings create unexpected results. #4003

Closed
freemanfromgodotengine opened this issue Mar 10, 2016 · 5 comments
Closed
Milestone

Comments

@freemanfromgodotengine
Copy link

Operating system or device:
xubuntu 14.04 64-bit running newly compiled Godot from github. Also confirmed with a versions from 3 days ago.

Issue description (what happened, and what was expected):

I would expect that Particle2D setting amount to 1, lifetime to 1, timescale 1, preprocess 0.1, emit timeout 0.9 and explosiveness to 1 would create exactly one particle emitted when is_emitting(true) is called (or just Emitting check box checked in Inspector).
However it does not.
You have to set amount to a higher value to see particle or particles emitted (they might be one on top of another).
Also, setting explosiveness to 0 seems buggy too. At 0 you must bump up timeout to 1.1 to see emitted particle or particles.

@freemanfromgodotengine freemanfromgodotengine changed the title Particle2D particles emitting settings created unexpected results. Particle2D emitting settings created unexpected results. Mar 10, 2016
@freemanfromgodotengine freemanfromgodotengine changed the title Particle2D emitting settings created unexpected results. Particle2D emitting settings creates unexpected results. Mar 10, 2016
@freemanfromgodotengine freemanfromgodotengine changed the title Particle2D emitting settings creates unexpected results. Particle2D emitting settings create unexpected results. Mar 10, 2016
@kubecz3k
Copy link
Contributor

@freemanfromgodotengine can you recheck on current main? thanks! :)

@freemanfromgodotengine
Copy link
Author

freemanfromgodotengine commented Aug 15, 2017

@kubecz3k I will try as soon as I will be back, but I will not be able to test in the same app, as in my case both, newest 2.1.1+ and master 3.0 version, get bugs, that prevent my apps from running properly at all.

@kubecz3k
Copy link
Contributor

@freemanfromgodotengine sure, I think it's quite safe to close the issue since particles were rewritten in 3.0 but some confirmation would be great :)

@pwab
Copy link

pwab commented Jan 7, 2018

Saw this on the #10239 tracker list.
I created a test project and the particles are working as expected.

Download sample project:
issue-4003.zip

amount to 1, lifetime to 1, timescale 1, preprocess 0.1, emit timeout 0.9 and explosiveness to 1

one_particle

explosiveness to 0

sun_burst

Seems to be fixed now.

@kubecz3k kubecz3k closed this as completed Jan 7, 2018
@kubecz3k kubecz3k added this to the 3.0 milestone Jan 7, 2018
@kubecz3k
Copy link
Contributor

kubecz3k commented Jan 7, 2018

@pwab nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants