Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to overwrite a non empty folder in trash with another one of the same name by deleting it gives error #46226

Closed
ghost opened this issue Feb 19, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Feb 19, 2021

Godot version:
3.2.3 stable

OS/device including version:
xubuntu 20.04

Issue description:
as stated in title, if you have a non empty folder in your trash and try to delete another folder of the same name inside godot's file system dock, it just replies with an unspecific error instead of telling you that it cant be overwritten because its not empty.
this means you would have to manually empty your trash to delete another folder of the same name.

i am aware that this probably relates to the missing trashinfo issue discussed in #44021 as it only happens when deleting files through godot and not through normal filemanagers, meaning godot just creates weird trash files

godot error is:
Cannot remove: res://folder_name

the terminal gives you this:
mv: cannot move '/home/user/project_name/folder_name/' to '/home/user/.local/share/Trash/files/folder_name': Directory not empty

Steps to reproduce:

  1. create folder in file system dock and put anything (folder, script, etc.) into it
  2. delete it through file system dock
  3. create new folder of the same name as first folder
  4. delete it through file system dock
  5. enjoy error message
@Calinou
Copy link
Member

Calinou commented May 28, 2022

I can't reproduce this on 3.5.rc 20c72e8 (Fedora 36 KDE). This was likely fixed by #44021.

This is what I get in the system trash after following the reproduction steps – no error messages are printed by Godot in the process.

image

@Calinou Calinou closed this as completed May 28, 2022
@Calinou Calinou added this to the 3.5 milestone May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant