Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom boot splash image scaling wrong on Android #46723

Closed
fractilegames opened this issue Mar 6, 2021 · 13 comments · Fixed by #47842
Closed

Custom boot splash image scaling wrong on Android #46723

fractilegames opened this issue Mar 6, 2021 · 13 comments · Fixed by #47842

Comments

@fractilegames
Copy link

Godot version:
3.2.4rc3

OS/device including version:
Samsung Galaxy S8, Android 9

Issue description:
With window size in project settings set to 1280x720 and using a custom boot splash image of the same size, only the middle 1/4 of the image is shown on Android:

Screenshot_20210306-120953_Polychoron

Changing Boot splash / full size -project setting does not change anything.

@Calinou
Copy link
Member

Calinou commented Mar 6, 2021

This is likely due to DPI scaling being automatically applied by the Android porting layer. Does this occur if you resize the splash image to 640×360?

@fractilegames
Copy link
Author

You're right. After resizing the image to 640x360 it shows up in correct size and position:
Screenshot_20210306-171309_Polychoron

@AlexHCC
Copy link
Contributor

AlexHCC commented Mar 13, 2021

I do have the same scaling issue with a high resolution image in a 720p phone screen. It is inconsistent with how it works on other platforms, and how it worked in previous versions (3.2.3).
Another maybe related inconsistency Is that the screen fades to black before starting the main scene. It is more apparent if you set the Bg Color to white. Again this does not happen in other platforms neither did it in previous versions (3.2.3), on the same device.

@Calinou
Copy link
Member

Calinou commented Mar 13, 2021

Another maybe related inconsistency Is that the screen fades to black before starting the main scene. It is more apparent if you set the Bg Color to white. Again this does not happen in other platforms neither did it in previous versions (3.2.3), on the same device.

This is probably related to the Android porting rework that happened between 3.2.3 and 3.2.4. Can you test this in all 3.2.4 betas and RCs?

@fractilegames
Copy link
Author

The problem is present in both 3.2.4rc1 and 3.2.4beta1.

@Calinou
Copy link
Member

Calinou commented Mar 13, 2021

cc @m4gr3d

@AlexHCC
Copy link
Contributor

AlexHCC commented Mar 14, 2021

I have tested the versions and recorded my results. I have used a 1000x1000 custom godot logo on a 720p phone screen (android). Here is the project I used.
In beta1-rc2 there is a scaled up version of the image before the correct one is shown. In rc3-rc5 the scaled up version remains but the correct one is replaced by a fade to a black screen.

3.2.3.mp4
beta1-rc2.mp4
rc3-rc5.mp4

@akien-mga akien-mga modified the milestones: 3.2, 3.3 Mar 17, 2021
@akien-mga
Copy link
Member

CC @godotengine/android

@m4gr3d
Copy link
Contributor

m4gr3d commented Apr 9, 2021

@fractilegames @AlexHCC The changes you are observing are intended and were done in PR #46168 in order to address issue #43726.

As mentioned in PR #46168, the use of the Android theme api introduces a couple of limitations, proper scaling being one of them.

Let me know if you have further questions on the current implementation.

@m4gr3d m4gr3d closed this as completed Apr 9, 2021
@fractilegames
Copy link
Author

That PR says "One limitation of the Android api being used is that the splash screen aspect ratio is not maintained when it's scaled up". This isn't just about aspect ratio, the image is scaled 2x too big on Android.

@m4gr3d
Copy link
Contributor

m4gr3d commented Apr 12, 2021

@fractilegames Thanks for the update, I'll take a look.

@ghost
Copy link

ghost commented Jul 31, 2022

@fractilegames Thanks for the update, I'll take a look.

The boot splash still has the same problem on godot 3.4.4... my splash image is scaling down. I am using a image same as my window size... Will it be fixe in feature?

@Calinou
Copy link
Member

Calinou commented Jul 31, 2022

The boot splash still has the same problem on godot 3.4.4... my splash image is scaling down. I am using a image same as my window size... Will it be fixe in feature?

This is already being tracked in #49816. There is no ETA for fixing this issue, as contributors work on a best-effort basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants