Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code editor auto complete feature must use scene hierarchy info to prevent cliping paths too early #4704

Closed
hubbyist opened this issue May 18, 2016 · 7 comments

Comments

@hubbyist
Copy link

Operating system or device - Godot version:
Using : Godot_v2.0.2_stable_x11.64 on linuxmint 17.2

auto complete list in code editor is cliping node paths depenging on the last letter written as illustrated below.

get_node("CenterContainer/VBoxContainer/Panel/Button$
         |CenterContainer/VBoxContainer/Panel/Button|
         |CenterContainer/VBoxContainer/Panel/Button|
         |CenterContainer/VBoxContainer/Panel/Button|
         |CenterContainer/VBoxContainer/Panel/Button|
         |CenterContainer/VBoxContainer/Panel/Button|
         |CenterContainer/VBoxContainer/Panel/Button|

It would be better to use biggest next word while listing nodes as below.

get_node("CenterContainer/VBoxContainer/Panel/Button$
         |CenterContainer/VBoxContainer/Panel/Button_Up   |
         |CenterContainer/VBoxContainer/Panel/Button_Down |
         |CenterContainer/VBoxContainer/Panel/Button_Aim  |
         |CenterContainer/VBoxContainer/Panel/ButtonGroup/|
         |CenterContainer/VBoxContainer/Panel/ButtonGroup/|
         |CenterContainer/VBoxContainer/Panel/ButtonL/Zone|
@akien-mga akien-mga added this to the 2.1 milestone May 18, 2016
@hubbyist hubbyist changed the title Code editor auto complete feature must use scene hierarchy info to prevent cliping paths to early Code editor auto complete feature must use scene hierarchy info to prevent cliping paths too early May 18, 2016
@akien-mga
Copy link
Member

Not critical for the upcoming 2.1, so moving to the next milestone.

@akien-mga akien-mga modified the milestones: 2.2, 2.1 Jul 15, 2016
@hubbyist
Copy link
Author

hubbyist commented Apr 27, 2017

Still happening in 2.1.3

godot_path_clipping

Additionally to original proposal some sort of path shortening may help as well I think.

get_node("CenterContainer/VBox...iner/Panel/Button$
         |CenterContainer/VBox...iner/Panel/Button_Up   |
         |CenterContainer/VBox...iner/Panel/Button_Down |
         |CenterContainer/VBox...iner/Panel/Button_Aim  |
         |CenterContainer/VBox...iner/Panel/ButtonGroup/|
         |CenterContainer/VBox...iner/Panel/ButtonGroup/|
         |CenterContainer/VBox...iner/Panel/ButtonL/Zone|

May also need a milestone update.

@akien-mga akien-mga removed this from the 2.2 milestone Apr 27, 2017
@AlexHolly
Copy link
Contributor

AlexHolly commented Mar 7, 2018

I am not sure if this approach helps much
image

Is there a reason to use canvasitem and not some Node with horizontal scroll?

@silverkorn
Copy link

Make it configurable?
Both ways seems good and useful but the expertise of the user might be the breaking point to get more on a path than another.

@AlexHolly, do you know if the dots could be on a different color/shading? This could avoid potential confusion.

@AlexHolly
Copy link
Contributor

@silverkorn I looked into the color thing I don't see an easy way for it.
I could probably make the whole line a different color if folding was applied.

Make it configurable?

You mean disable folding? I don't see any benefit.
The folding should only happen when really needed and only as far as needed to fit.

To me this looks like a temporary solution anyway. To solve this issue some horizontal scroll is needed.

@silverkorn
Copy link

silverkorn commented Mar 9, 2018

@AlexHolly, sorry, I meant the different ways to see the auto-completion list.
But otherwise, indeed, an horizontal scrollbar would be needed. I wasn't aware that all those suggestions were for a workaround.

@Calinou
Copy link
Member

Calinou commented Jun 18, 2020

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.

The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.

If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants