Creating editor feature profiles doesn't work

[foxydevloper]

Godot version:
v4.0.dev.custom_build.8b06d4275

OS/device including version:
Windows 10

Issue description:
Creating editor feature profiles doesn't work. It just puts this in the console whenever tried:

ERROR: Cannot create file 'feature_profiles/newprofile.profile'.
   at: (editor\editor_feature_profile.cpp:200)
ERROR: Cannot open directory 'feature_profiles'.
   at: (editor\editor_feature_profile.cpp:351)

2021-06-02_11-53-09.mp4

Steps to reproduce:

• Create new project
• Open Manage Editor Features...
• Press Create Profile

Minimal reproduction project:
new project

[Calinou]

How did you start Godot? There's an issue on Windows where an incorrect CWD (such as C:\Windows\System32\) can cause Godot to try to write files to an invalid directory.

Also, does this occur if you move the Godot executable to the C: drive and run it there?

[foxydevloper]

How did you start Godot? There's an issue on Windows where an incorrect CWD (such as C:\Windows\System32\) can cause Godot to try to write files to an invalid directly.

Also, does this occur if you move the Godot executable to the C: drive and run it there?

I downloaded the windows-editor zip from github actions so I didn't have to compile

Issue still appears when I move it to C:

[YuriSizov]

@Calinou While I've noticed the same issue while debugging, it still happens if you run the executable directly.

[timothyqiu]

I also experienced the same issue on macOS.

[Calinou]

I can confirm this on Linux too:

❯ godot-init /tmp/b
Godot Engine v4.0.dev.custom_build.ff648e250 - https://godotengine.org
Vulkan API 1.2.162
Using Vulkan Device #0: NVIDIA - NVIDIA GeForce GTX 1080
- Vulkan multiview supported:
  max views: 32
  max instances: 134217727
- Vulkan subgroup:
  size: 32
  stages: STAGE_VERTEX, STAGE_TESSELLATION_CONTROL, STAGE_TESSELLATION_EVALUATION, STAGE_GEOMETRY, STAGE_FRAGMENT, STAGE_COMPUTE, STAGE_RAYGEN_KHR, STAGE_ANY_HIT_KHR, STAGE_CLOSEST_HIT_KHR, STAGE_MISS_KHR, STAGE_INTERSECTION_KHR, STAGE_CALLABLE_KHR
  supported ops: FEATURE_BASIC, FEATURE_VOTE, FEATURE_ARITHMETIC, FEATURE_BALLOT, FEATURE_SHUFFLE, FEATURE_SHUFFLE_RELATIVE, FEATURE_CLUSTERED, FEATURE_QUAD, FEATURE_PARTITIONED_NV
  quad operations in all stages
 
ERROR: Error loading default feature profile: dddsds
   at: _notification (editor/editor_feature_profile.cpp:303)
ERROR: Cannot open directory 'feature_profiles'.
   at: _update_profile_list (editor/editor_feature_profile.cpp:336)

(godot-init creates a brand new project and edits it with my Godot binary.)

Going into Editor > Manage Feature Profiles... does not display any profiles to choose from.

[YuriSizov]

This was accidentally broken by #49050. There used to be get_settings_dir exposed and used across the editor to retrieve the root of the settings/configuration directory. It is used by feature profiles, as well as script templates for example. In #49050 during refactoring an internal variable config_dir was exposed via get_config_dir, and settings_dir while kept exposed was never set.

They should be the same variable/getter, so we need to pick one. I'll talk with @reduz which one to keep and make a PR fixing this issue.