Use property binding macros instead of _set / _get override in Skeleton2D

[pouleyKetchoupp]

Godot version:
Master 94c31ba

OS/device including version:
All platforms

Issue description:
Following merge of #47872 (see discussion in #40347 for more details), some 2D skeleton classes need cleanup around property usage.

The following classes need to be reviewed to see if _set / _get overrides can be replaced with standard binding macros.

Bone2D:

godot/scene/2d/skeleton_2d.cpp

Lines 40 to 82 in 94c31ba

	bool Bone2D::_set(const StringName &p_path, const Variant &p_value) {
	String path = p_path;
	if (path.begins_with("auto_calculate_length_and_angle")) {
	set_autocalculate_length_and_angle(p_value);
	} else if (path.begins_with("length")) {
	set_length(p_value);
	} else if (path.begins_with("bone_angle")) {
	set_bone_angle(Math::deg2rad(float(p_value)));
	} else if (path.begins_with("default_length")) {
	set_length(p_value);
	}
	#ifdef TOOLS_ENABLED
	if (path.begins_with("editor_settings/show_bone_gizmo")) {
	_editor_set_show_bone_gizmo(p_value);
	}
	#endif // TOOLS_ENABLED
	return true;
	}
	bool Bone2D::_get(const StringName &p_path, Variant &r_ret) const {
	String path = p_path;
	if (path.begins_with("auto_calculate_length_and_angle")) {
	r_ret = get_autocalculate_length_and_angle();
	} else if (path.begins_with("length")) {
	r_ret = get_length();
	} else if (path.begins_with("bone_angle")) {
	r_ret = Math::rad2deg(get_bone_angle());
	} else if (path.begins_with("default_length")) {
	r_ret = get_length();
	}
	#ifdef TOOLS_ENABLED
	if (path.begins_with("editor_settings/show_bone_gizmo")) {
	r_ret = _editor_get_show_bone_gizmo();
	}
	#endif // TOOLS_ENABLED
	return true;
	}

Skeleton2D:

godot/scene/2d/skeleton_2d.cpp

Lines 537 to 555 in 94c31ba

	bool Skeleton2D::_set(const StringName &p_path, const Variant &p_value) {
	String path = p_path;
	if (path.begins_with("modification_stack")) {
	set_modification_stack(p_value);
	return true;
	}
	return true;
	}
	bool Skeleton2D::_get(const StringName &p_path, Variant &r_ret) const {
	String path = p_path;
	if (path.begins_with("modification_stack")) {
	r_ret = get_modification_stack();
	return true;
	}
	return true;
	}

SkeletonModificationStack2D:

godot/scene/resources/skeleton_modification_stack_2d.cpp

Lines 44 to 64 in 94c31ba

	bool SkeletonModificationStack2D::_set(const StringName &p_path, const Variant &p_value) {
	String path = p_path;
	if (path.begins_with("modifications/")) {
	int mod_idx = path.get_slicec('/', 1).to_int();
	set_modification(mod_idx, p_value);
	return true;
	}
	return true;
	}
	bool SkeletonModificationStack2D::_get(const StringName &p_path, Variant &r_ret) const {
	String path = p_path;
	if (path.begins_with("modifications/")) {
	int mod_idx = path.get_slicec('/', 1).to_int();
	r_ret = get_modification(mod_idx);
	return true;
	}
	return true;
	}

SkeletonModification2DCCDIK:

godot/scene/resources/skeleton_modification_2d_ccdik.cpp

Lines 38 to 124 in 94c31ba

	bool SkeletonModification2DCCDIK::_set(const StringName &p_path, const Variant &p_value) {
	String path = p_path;
	if (path.begins_with("joint_data/")) {
	int which = path.get_slicec('/', 1).to_int();
	String what = path.get_slicec('/', 2);
	ERR_FAIL_INDEX_V(which, ccdik_data_chain.size(), false);
	if (what == "bone2d_node") {
	set_ccdik_joint_bone2d_node(which, p_value);
	} else if (what == "bone_index") {
	set_ccdik_joint_bone_index(which, p_value);
	} else if (what == "rotate_from_joint") {
	set_ccdik_joint_rotate_from_joint(which, p_value);
	} else if (what == "enable_constraint") {
	set_ccdik_joint_enable_constraint(which, p_value);
	} else if (what == "constraint_angle_min") {
	set_ccdik_joint_constraint_angle_min(which, Math::deg2rad(float(p_value)));
	} else if (what == "constraint_angle_max") {
	set_ccdik_joint_constraint_angle_max(which, Math::deg2rad(float(p_value)));
	} else if (what == "constraint_angle_invert") {
	set_ccdik_joint_constraint_angle_invert(which, p_value);
	} else if (what == "constraint_in_localspace") {
	set_ccdik_joint_constraint_in_localspace(which, p_value);
	}
	#ifdef TOOLS_ENABLED
	if (what.begins_with("editor_draw_gizmo")) {
	set_ccdik_joint_editor_draw_gizmo(which, p_value);
	}
	#endif // TOOLS_ENABLED
	return true;
	}
	#ifdef TOOLS_ENABLED
	if (path.begins_with("editor/draw_gizmo")) {
	set_editor_draw_gizmo(p_value);
	}
	#endif // TOOLS_ENABLED
	return true;
	}
	bool SkeletonModification2DCCDIK::_get(const StringName &p_path, Variant &r_ret) const {
	String path = p_path;
	if (path.begins_with("joint_data/")) {
	int which = path.get_slicec('/', 1).to_int();
	String what = path.get_slicec('/', 2);
	ERR_FAIL_INDEX_V(which, ccdik_data_chain.size(), false);
	if (what == "bone2d_node") {
	r_ret = get_ccdik_joint_bone2d_node(which);
	} else if (what == "bone_index") {
	r_ret = get_ccdik_joint_bone_index(which);
	} else if (what == "rotate_from_joint") {
	r_ret = get_ccdik_joint_rotate_from_joint(which);
	} else if (what == "enable_constraint") {
	r_ret = get_ccdik_joint_enable_constraint(which);
	} else if (what == "constraint_angle_min") {
	r_ret = Math::rad2deg(get_ccdik_joint_constraint_angle_min(which));
	} else if (what == "constraint_angle_max") {
	r_ret = Math::rad2deg(get_ccdik_joint_constraint_angle_max(which));
	} else if (what == "constraint_angle_invert") {
	r_ret = get_ccdik_joint_constraint_angle_invert(which);
	} else if (what == "constraint_in_localspace") {
	r_ret = get_ccdik_joint_constraint_in_localspace(which);
	}
	#ifdef TOOLS_ENABLED
	if (what.begins_with("editor_draw_gizmo")) {
	r_ret = get_ccdik_joint_editor_draw_gizmo(which);
	}
	#endif // TOOLS_ENABLED
	return true;
	}
	#ifdef TOOLS_ENABLED
	if (path.begins_with("editor/draw_gizmo")) {
	r_ret = get_editor_draw_gizmo();
	}
	#endif // TOOLS_ENABLED
	return true;
	}

SkeletonModification2DFABRIK:

godot/scene/resources/skeleton_modification_2d_fabrik.cpp

Lines 38 to 80 in 94c31ba

	bool SkeletonModification2DFABRIK::_set(const StringName &p_path, const Variant &p_value) {
	String path = p_path;
	if (path.begins_with("joint_data/")) {
	int which = path.get_slicec('/', 1).to_int();
	String what = path.get_slicec('/', 2);
	ERR_FAIL_INDEX_V(which, fabrik_data_chain.size(), false);
	if (what == "bone2d_node") {
	set_fabrik_joint_bone2d_node(which, p_value);
	} else if (what == "bone_index") {
	set_fabrik_joint_bone_index(which, p_value);
	} else if (what == "magnet_position") {
	set_fabrik_joint_magnet_position(which, p_value);
	} else if (what == "use_target_rotation") {
	set_fabrik_joint_use_target_rotation(which, p_value);
	}
	}
	return true;
	}
	bool SkeletonModification2DFABRIK::_get(const StringName &p_path, Variant &r_ret) const {
	String path = p_path;
	if (path.begins_with("joint_data/")) {
	int which = path.get_slicec('/', 1).to_int();
	String what = path.get_slicec('/', 2);
	ERR_FAIL_INDEX_V(which, fabrik_data_chain.size(), false);
	if (what == "bone2d_node") {
	r_ret = get_fabrik_joint_bone2d_node(which);
	} else if (what == "bone_index") {
	r_ret = get_fabrik_joint_bone_index(which);
	} else if (what == "magnet_position") {
	r_ret = get_fabrik_joint_magnet_position(which);
	} else if (what == "use_target_rotation") {
	r_ret = get_fabrik_joint_use_target_rotation(which);
	}
	return true;
	}
	return true;
	}

SkeletonModification2DJiggle:

godot/scene/resources/skeleton_modification_2d_jiggle.cpp

Lines 34 to 104 in 94c31ba

	bool SkeletonModification2DJiggle::_set(const StringName &p_path, const Variant &p_value) {
	String path = p_path;
	if (path.begins_with("joint_data/")) {
	int which = path.get_slicec('/', 1).to_int();
	String what = path.get_slicec('/', 2);
	ERR_FAIL_INDEX_V(which, jiggle_data_chain.size(), false);
	if (what == "bone2d_node") {
	set_jiggle_joint_bone2d_node(which, p_value);
	} else if (what == "bone_index") {
	set_jiggle_joint_bone_index(which, p_value);
	} else if (what == "override_defaults") {
	set_jiggle_joint_override(which, p_value);
	} else if (what == "stiffness") {
	set_jiggle_joint_stiffness(which, p_value);
	} else if (what == "mass") {
	set_jiggle_joint_mass(which, p_value);
	} else if (what == "damping") {
	set_jiggle_joint_damping(which, p_value);
	} else if (what == "use_gravity") {
	set_jiggle_joint_use_gravity(which, p_value);
	} else if (what == "gravity") {
	set_jiggle_joint_gravity(which, p_value);
	}
	return true;
	} else {
	if (path == "use_colliders") {
	set_use_colliders(p_value);
	} else if (path == "collision_mask") {
	set_collision_mask(p_value);
	}
	}
	return true;
	}
	bool SkeletonModification2DJiggle::_get(const StringName &p_path, Variant &r_ret) const {
	String path = p_path;
	if (path.begins_with("joint_data/")) {
	int which = path.get_slicec('/', 1).to_int();
	String what = path.get_slicec('/', 2);
	ERR_FAIL_INDEX_V(which, jiggle_data_chain.size(), false);
	if (what == "bone2d_node") {
	r_ret = get_jiggle_joint_bone2d_node(which);
	} else if (what == "bone_index") {
	r_ret = get_jiggle_joint_bone_index(which);
	} else if (what == "override_defaults") {
	r_ret = get_jiggle_joint_override(which);
	} else if (what == "stiffness") {
	r_ret = get_jiggle_joint_stiffness(which);
	} else if (what == "mass") {
	r_ret = get_jiggle_joint_mass(which);
	} else if (what == "damping") {
	r_ret = get_jiggle_joint_damping(which);
	} else if (what == "use_gravity") {
	r_ret = get_jiggle_joint_use_gravity(which);
	} else if (what == "gravity") {
	r_ret = get_jiggle_joint_gravity(which);
	}
	return true;
	} else {
	if (path == "use_colliders") {
	r_ret = get_use_colliders();
	} else if (path == "collision_mask") {
	r_ret = get_collision_mask();
	}
	}
	return true;
	}

SkeletonModification2DLookAt:

godot/scene/resources/skeleton_modification_2d_lookat.cpp

Lines 38 to 88 in 94c31ba

	bool SkeletonModification2DLookAt::_set(const StringName &p_path, const Variant &p_value) {
	String path = p_path;
	if (path.begins_with("enable_constraint")) {
	set_enable_constraint(p_value);
	} else if (path.begins_with("constraint_angle_min")) {
	set_constraint_angle_min(Math::deg2rad(float(p_value)));
	} else if (path.begins_with("constraint_angle_max")) {
	set_constraint_angle_max(Math::deg2rad(float(p_value)));
	} else if (path.begins_with("constraint_angle_invert")) {
	set_constraint_angle_invert(p_value);
	} else if (path.begins_with("constraint_in_localspace")) {
	set_constraint_in_localspace(p_value);
	} else if (path.begins_with("additional_rotation")) {
	set_additional_rotation(Math::deg2rad(float(p_value)));
	}
	#ifdef TOOLS_ENABLED
	if (path.begins_with("editor/draw_gizmo")) {
	set_editor_draw_gizmo(p_value);
	}
	#endif // TOOLS_ENABLED
	return true;
	}
	bool SkeletonModification2DLookAt::_get(const StringName &p_path, Variant &r_ret) const {
	String path = p_path;
	if (path.begins_with("enable_constraint")) {
	r_ret = get_enable_constraint();
	} else if (path.begins_with("constraint_angle_min")) {
	r_ret = Math::rad2deg(get_constraint_angle_min());
	} else if (path.begins_with("constraint_angle_max")) {
	r_ret = Math::rad2deg(get_constraint_angle_max());
	} else if (path.begins_with("constraint_angle_invert")) {
	r_ret = get_constraint_angle_invert();
	} else if (path.begins_with("constraint_in_localspace")) {
	r_ret = get_constraint_in_localspace();
	} else if (path.begins_with("additional_rotation")) {
	r_ret = Math::rad2deg(get_additional_rotation());
	}
	#ifdef TOOLS_ENABLED
	if (path.begins_with("editor/draw_gizmo")) {
	r_ret = get_editor_draw_gizmo();
	}
	#endif // TOOLS_ENABLED
	return true;
	}

SkeletonModification2DPhysicalBones:

godot/scene/resources/skeleton_modification_2d_physicalbones.cpp

Lines 35 to 86 in 94c31ba

	bool SkeletonModification2DPhysicalBones::_set(const StringName &p_path, const Variant &p_value) {
	String path = p_path;
	#ifdef TOOLS_ENABLED
	// Exposes a way to fetch the PhysicalBone2D nodes from the Godot editor.
	if (is_setup) {
	if (Engine::get_singleton()->is_editor_hint()) {
	if (path.begins_with("fetch_bones")) {
	fetch_physical_bones();
	notify_property_list_changed();
	return true;
	}
	}
	}
	#endif //TOOLS_ENABLED
	if (path.begins_with("joint_")) {
	int which = path.get_slicec('_', 1).to_int();
	String what = path.get_slicec('_', 2);
	ERR_FAIL_INDEX_V(which, physical_bone_chain.size(), false);
	if (what == "nodepath") {
	set_physical_bone_node(which, p_value);
	}
	return true;
	}
	return true;
	}
	bool SkeletonModification2DPhysicalBones::_get(const StringName &p_path, Variant &r_ret) const {
	String path = p_path;
	#ifdef TOOLS_ENABLED
	if (Engine::get_singleton()->is_editor_hint()) {
	if (path.begins_with("fetch_bones")) {
	return true; // Do nothing!
	}
	}
	#endif //TOOLS_ENABLED
	if (path.begins_with("joint_")) {
	int which = path.get_slicec('_', 1).to_int();
	String what = path.get_slicec('_', 2);
	ERR_FAIL_INDEX_V(which, physical_bone_chain.size(), false);
	if (what == "nodepath") {
	r_ret = get_physical_bone_node(which);
	}
	return true;
	}
	return true;
	}

SkeletonModification2DStackHolder:

godot/scene/resources/skeleton_modification_2d_stackholder.cpp

Lines 34 to 64 in 94c31ba

	bool SkeletonModification2DStackHolder::_set(const StringName &p_path, const Variant &p_value) {
	String path = p_path;
	if (path == "held_modification_stack") {
	set_held_modification_stack(p_value);
	}
	#ifdef TOOLS_ENABLED
	if (path == "editor/draw_gizmo") {
	set_editor_draw_gizmo(p_value);
	}
	#endif // TOOLS_ENABLED
	return true;
	}
	bool SkeletonModification2DStackHolder::_get(const StringName &p_path, Variant &r_ret) const {
	String path = p_path;
	if (path == "held_modification_stack") {
	r_ret = get_held_modification_stack();
	}
	#ifdef TOOLS_ENABLED
	if (path == "editor/draw_gizmo") {
	r_ret = get_editor_draw_gizmo();
	}
	#endif // TOOLS_ENABLED
	return true;
	}

SkeletonModification2DTwoBoneIK:

godot/scene/resources/skeleton_modification_2d_twoboneik.cpp

Lines 38 to 84 in 94c31ba

	bool SkeletonModification2DTwoBoneIK::_set(const StringName &p_path, const Variant &p_value) {
	String path = p_path;
	if (path == "joint_one_bone_idx") {
	set_joint_one_bone_idx(p_value);
	} else if (path == "joint_one_bone2d_node") {
	set_joint_one_bone2d_node(p_value);
	} else if (path == "joint_two_bone_idx") {
	set_joint_two_bone_idx(p_value);
	} else if (path == "joint_two_bone2d_node") {
	set_joint_two_bone2d_node(p_value);
	}
	#ifdef TOOLS_ENABLED
	if (path.begins_with("editor/draw_gizmo")) {
	set_editor_draw_gizmo(p_value);
	} else if (path.begins_with("editor/draw_min_max")) {
	set_editor_draw_min_max(p_value);
	}
	#endif // TOOLS_ENABLED
	return true;
	}
	bool SkeletonModification2DTwoBoneIK::_get(const StringName &p_path, Variant &r_ret) const {
	String path = p_path;
	if (path == "joint_one_bone_idx") {
	r_ret = get_joint_one_bone_idx();
	} else if (path == "joint_one_bone2d_node") {
	r_ret = get_joint_one_bone2d_node();
	} else if (path == "joint_two_bone_idx") {
	r_ret = get_joint_two_bone_idx();
	} else if (path == "joint_two_bone2d_node") {
	r_ret = get_joint_two_bone2d_node();
	}
	#ifdef TOOLS_ENABLED
	if (path.begins_with("editor/draw_gizmo")) {
	r_ret = get_editor_draw_gizmo();
	} else if (path.begins_with("editor/draw_min_max")) {
	r_ret = get_editor_draw_min_max();
	}
	#endif // TOOLS_ENABLED
	return true;
	}

Steps to reproduce:
n/a

Minimal reproduction project:
n/a