Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] DDS files in inspector crashes engine #50898

Closed
TokisanGames opened this issue Jul 26, 2021 · 3 comments
Closed

[3.x] DDS files in inspector crashes engine #50898

TokisanGames opened this issue Jul 26, 2021 · 3 comments

Comments

@TokisanGames
Copy link
Contributor

Godot version

v3.4.beta.custom_build.0b4080ba4

System information

Win 10/64 NVIDIA GeForce GTX 1060/PCIe/SSE2

Issue description

I have hundreds of DDS textures, bc1 and bc3. They work fine except when looking at them in the inspector with current build.

In 3.4-beta 0b4080b, if you double-click a DDS file, the engine crashes.

ERROR: Could not call function '_save_thread_func' to start thread 2484165113489756807: Too Few Arguments.
   at: (core\bind\core_bind.cpp:2616)
ERROR: Expected data size of 67108912 bytes in Image::create(), got instead 67108896 bytes.
   at: (core\image.cpp:1773)
ERROR: Invalid image
   at: (scene\resources\texture.cpp:190)
ERROR: Expected data size of 67108912 bytes in Image::create(), got instead 67108896 bytes.
   at: (core\image.cpp:1773)
ERROR: Invalid image
   at: (scene\resources\texture.cpp:190)
ERROR: Expected data size of 67108912 bytes in Image::create(), got instead 67108896 bytes.
   at: (core\image.cpp:1773)
ERROR: Invalid image
   at: (scene\resources\texture.cpp:190)
CrashHandlerException: Program crashed
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[0] embree::TaskScheduler::wait
[1] embree::TaskScheduler::wait
[2] embree::TaskScheduler::wait
[3] embree::TaskScheduler::wait
[4] embree::TaskScheduler::wait
[5] embree::TaskScheduler::wait
[6] embree::TaskScheduler::wait
[7] embree::TaskScheduler::wait
[8] embree::TaskScheduler::wait
[9] embree::TaskScheduler::wait
[10] embree::TaskScheduler::wait
[11] embree::TaskScheduler::wait
[12] embree::TaskScheduler::wait
[13] embree::TaskScheduler::wait
[14] embree::TaskScheduler::wait
[15] embree::TaskScheduler::wait
[16] embree::TaskScheduler::wait
[17] embree::TaskScheduler::wait
[18] embree::TaskScheduler::wait
[19] embree::TaskScheduler::wait
[20] embree::TaskScheduler::wait
[21] embree::TaskScheduler::wait
[22] embree::TaskScheduler::wait
[23] embree::TaskScheduler::wait
[24] embree::TaskScheduler::wait
[25] embree::TaskScheduler::wait
[26] embree::TaskScheduler::wait
[27] embree::TaskScheduler::wait
[28] main
[29] main
[30] main
[31] widechar_main
[32] _main
[33] main
[34] embree::TaskScheduler::wait
[35] BaseThreadInitThunk
-- END OF BACKTRACE --

Doing this in 3.3.2 does not crash the engine. It loads up and displays most DDS files, however I have some large 8192x6144 files that the inspector won't display in the preview. The type is 0x0 Lum8, when it should be 8192x6144 DXT5 RGBA8.

Steps to reproduce

See above.

Minimal reproduction project

No response

@akien-mga
Copy link
Member

Might be related to #50647 (i.e. possibly a regression from #47854).

@akien-mga
Copy link
Member

Your build is a few days old though and lacks #50745 and subsequent fixes, so it would be good if you could check latest 3.x.

@TokisanGames
Copy link
Contributor Author

The inspector still doesn't understand large DDS textures (eg 8k x 6k), but at least it no longer crashes on any DDS textures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants