Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan: LightmapGI indirect bounces with a lot of artifacts #53770

Closed
jcostello opened this issue Oct 13, 2021 · 3 comments · Fixed by #54919
Closed

Vulkan: LightmapGI indirect bounces with a lot of artifacts #53770

jcostello opened this issue Oct 13, 2021 · 3 comments · Fixed by #54919
Labels
bug topic:rendering topic:3d
Milestone
4.0

Comments

@jcostello
Copy link
Contributor

jcostello commented Oct 13, 2021 •
edited
Loading

Godot version

v4.0.dev.custom_build [6eff4c1]

System information

Ubuntu 21.04. RTX 2060

Issue description

LightmapGI indirect bounces have a lot of artifacts

image

Steps to reproduce

Use Test3.tscn scene from the minimum reproduction project.

Minimal reproduction project

https://drive.google.com/file/d/1XbWk4HVYI-fH7PyzetGVKmUQ8O5VoEOq/view?usp=sharing
@Calinou Calinou added this to the 4.0 milestone Oct 13, 2021
@Calinou Calinou changed the title LightmapGI indirect bounces with a lot of artifacts. Vulkan: LightmapGI indirect bounces with a lot of artifacts Oct 13, 2021
@Calinou
Copy link
Member

Calinou commented Oct 13, 2021

@jcostello Can you reproduce this after enabling Use Denoiser then baking lightmaps again?

@jcostello
Copy link
Contributor Author

jcostello commented Oct 13, 2021 •
edited
Loading

@Calinou Yes, with the denoiser you have the same issue only more blurry. I left the denoiser off to show the patches in the baked lightmap

@jcostello
Copy link
Contributor Author

@Calinou with denoiser

image

@jcostello jcostello mentioned this issue Oct 19, 2021
Closed
@williamd67 williamd67 mentioned this issue Nov 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

GPULightmapper: better algorithm to generate rays for indirect lighting williamd67/godot
2 participants
@Calinou @jcostello