Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on master on Godot ik. #53794

Closed
fire opened this issue Oct 14, 2021 · 2 comments · Fixed by #53821
Closed

Regression on master on Godot ik. #53794

fire opened this issue Oct 14, 2021 · 2 comments · Fixed by #53821

Comments

@fire
Copy link
Member

fire commented Oct 14, 2021

Godot version

d956904

System information

Win11, RTX 3000 series

Issue description

Master regressed on SkeletonModifierStack3D.

The arms are not taking rest pose in the calculation. (Animation now have to include rest pose).

#53765

@TwistedTwigleg

Steps to reproduce

This character broken when IK is enabled. res://skeleton_modification/scenes/skeleton_test_08_character_full/Skeleton_Test_08.tscn

Minimal reproduction project

https://github.com/TwistedTwigleg/Godot_GSOC_2020_Project

@TwistedTwigleg
Copy link
Contributor

I'll take a look once I can and see if I can get it working again 👍

@TwistedTwigleg
Copy link
Contributor

I started working on a fix and made a draft PR #53821. FABRIK is the only modifier not working currently in the draft PR and I'll try to see if I can get it working fully once I can. 👍

(Side note: I'm not sure regression is a proper tag for this, as it seems like it's a normal bug caused by the compatibility breaking changes in #53765, but I digress)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants