"Invalid call. Nonexistent built-in function 'convert'." from script

[bojidar-bg]

Operating system or device - Godot version:
Arch linux -- Godot master ( 119cd5d )

Issue description (what happened, and what was expected):
I was playing around with some code until Invalid call. Nonexistent built-in function 'convert'. came up.

Steps to reproduce:

• Add this script to a random node:

func _ready():
    print(convert("1,2", TYPE_VECTOR2))

• Hit play and watch.

Edit: looks like one can't convert a String to a Vector2 -- oops! Anyway, the error message is as misleading as possible, and would be nice if it is fixed ^^

Link to minimal example project (optional but very welcome):

[vnen]

This happens because when the constructor fails, it returns a CALL_ERROR_INVALID_METHOD: https://github.com/godotengine/godot/blob/master/core/variant_call.cpp#L1133

Which for GDScript means a non-existent function:

godot/modules/gdscript/gd_function.cpp

Line 98 in 36e7544

} else if (p_err.error==Variant::CallError::CALL_ERROR_INVALID_METHOD) {

[bojidar-bg]

Anyway, the message is very, very misleading ^^

[Piet-G]

Still relevant in master

[KoBeWi]

In 0524853 the error says Invalid call for function "Convert". IMO we should just remove this function, casting is super-simple to do and more reliable. The fact that I learned about convert() from this issue doesn't help.

[Xrayez]

If casting allows to convert all supported Variant types, then yeah I think it makes sense to remove convert from GDScript, unless it's not exactly the same thing.

The following produces equivalent result (3.2):

func _ready():
	print("Vector2(0, 0)" as int) # prints 200
	print(convert("Vector2(0, 0)", TYPE_INT)) # prints 200

So I suspect casting uses the same conversion mechanism then (not sure why or how it converted Vector2(0, 0) to 200, though).

[KoBeWi]

(not sure why or how it converted Vector2(0, 0) to 200, though).

Vector2(0, 0) -> 200
That's how int("str") method works. So there are 3 ways to convert stuff right now.

Also I tried using convert() on master and it's broken. E.g. it can't convert string to int.