Clicking on a blend shape crashes with Toasts

[fire]

Godot version

4.0 52b7d5f

System information

Windows 11, Nvidia 3000 series

Issue description

Opening a glb and then clicking on a mesh blend shape menu crashes.

Steps to reproduce

See issue description.

In

void RenderingDeviceVulkan::_free_internal(RID p_id) {}
// ...
} else if (compute_pipeline_owner.owns(p_id)) {
ComputePipeline *pipeline = compute_pipeline_owner.get_or_null(p_id);
frames[frame].compute_pipelines_to_dispose_of.push_back(*pipeline);
compute_pipeline_owner.free(p_id);
} else {
ERR_PRINT("Attempted to free invalid ID: " + itos(p_id.get_id()));
}

Remove the else case to avoid the infinite loop that causes the crash.

Minimal reproduction project

https://github.com/KhronosGroup/glTF-Sample-Models/blob/0bc2ad7535aba4e16fb1afba1f85fd827bbbea6d/2.0/MorphStressTest/glTF-Binary/MorphStressTest.glb

Blend Shape Crash Game Project.zip

[fire]

Fixed d394cbc?? Not sure.

[fire]

The crash seems to happen when I'm in debug mode and toasts are showing printing an error in vulkan of that quoted place.

[fire]

[lentsius-bark]

I can confirm this bug happens when I try to either see the blend shapes or click on the toast notification icon. Happens with both the test files provided as well as my own exported meshes that have blend shapes.

Turning off toast notifications (interface/editor/show_internal_errors_in_toast_notifications) in editor settings stops the editor from crashing.

Windows 11, Nvidia GeForce 1060 GTX, Godot v4.0.dev.calinou [4f29823]

[lyuma]

Displaying toasts from a different thread might be hitting the editor thread safety issues. Let's try again after #71280 is merged.

[clayjohn]

This seems like it may have been fixed by #71553 actually which fixed a bug where we were getting deadlocks/crashes from toasts when we had shader compilation issues

[RandomShaper]

Not able to reproduce it, even without any of the aforementioned PRs (even if reverting #71553).

@fire, @lentsius-bark, are you still able to reproduce it?

[smix8]

I think this is fixed in Godot 4, I can not reproduce the issue in recent master.

[fire]

Closing due to testing.