Node.replace_by leaves duplicates

[Shadowblitz16]

Godot version

3.4

System information

Kubuntu 20.04 GLES3 Ryzan 7 5700G with Radeon Graphics

Issue description

Node.replace_by seems to leave odd duplicates in the remote tree

func _process(delta):
	if  _can_shoot && InputMap.has_action(projectile_action) && Input.is_action_pressed(projectile_action):
		if  _projectile_scene != projectile_scene:
			_projectile_scene  = projectile_scene
			BULLET.replace_by(_projectile_scene.instance(), true)
			
		if  _projectile_scene != null:	
			_can_shoot = false
			emit_signal("fire")

Steps to reproduce

• download this https://github.com/Shadowblitz16/AstroWars/releases/tag/Node.replace_by-bug
• look in the remote scene tab under root/Weapon/Bullet after pressing space

Minimal reproduction project

See above

[KoBeWi]

It's not a bug, just undocumented behavior. Seems like replace_by doesn't replace whole branch, but only that one node and moves all its children to the new node. In your case the two bullets will have their children lists merged.

[Shadowblitz16]

I hear that excuse not a bug a lot here.
Maybe instead of having weird behaviors in the engine that don't make sense you should consider fixing it.