Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draw_line thickness regression in 3.x branch #55920

Closed
EIREXE opened this issue Dec 14, 2021 · 4 comments
Closed

draw_line thickness regression in 3.x branch #55920

EIREXE opened this issue Dec 14, 2021 · 4 comments

Comments

@EIREXE
Copy link
Contributor

EIREXE commented Dec 14, 2021

Godot version

3.x (4cae48d)

System information

Windows 11 and Arch

Issue description

The behavior of draw_line has changed from the stable 3.3.4 branch, now lines seem to be twice as thick with the same thickness value.

3.3.4 (before):

3.x (after):

(Note the thickness difference in the lines at the bottom of the screen)

Steps to reproduce

Run:

func _draw():
    draw_line(Vector2(0, 100), Vector2(200, 100), Color.blue, 3)

And observe how it's different on different versions of the engine.

Minimal reproduction project

No response

@Calinou
Copy link
Member

Calinou commented Dec 14, 2021

@EIREXE Which stretch mode are you using in your project? This will affect line thickness depending on the window size.

@EIREXE
Copy link
Contributor Author

EIREXE commented Dec 14, 2021

@EIREXE Which stretch mode are you using in your project? This will affect line thickness depending on the window size.

I am using stretch mode 2d with aspect expand

@lawnjelly
Copy link
Member

Ah that might be me, I recently faffed with thick line drawing in #54377.

Ah yes I can see it already, the multiplier should probably be half the width. I'll test this and make a PR to fix. 👍

@lawnjelly
Copy link
Member

Fixed by #55922 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants