Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New in-editor error popups can extend off-screen #57472

Closed
snailrhymer opened this issue Jan 31, 2022 · 5 comments · Fixed by #71563
Closed

New in-editor error popups can extend off-screen #57472

snailrhymer opened this issue Jan 31, 2022 · 5 comments · Fixed by #71563

Comments

@snailrhymer
Copy link
Contributor

snailrhymer commented Jan 31, 2022

Godot version

v4.0.alpha.custom_build [78e3e65]

System information

Windows 10

Issue description

The new error popups don't wrap text or otherwise handle longer text, so they can extend off-screen:

image

Since the errors are left-justified as a block, long errors can push shorter ones off-screen:

image

Popups don't seem to have been introduced in v4.0.alpha1.official [31a7ddb], so I haven't been able to reproduce the behaviour there.

**Edit: ** The bug also appears in alpha 1.

Steps to reproduce

Cause a sufficiently long error message to popup in the editor, e.g. with

@tool
extends Node

func _process(delta):
    var a
    a.loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong_function_name()

attached to a node in the scene tree.

Minimal reproduction project

No response

@Calinou
Copy link
Member

Calinou commented Jan 31, 2022

Popups don't seem to have been introduced in v4.0.alpha1.official [31a7ddb], so I haven't been able to reproduce the behaviour there.

Toasts were already implemented in 4.0alpha1, but did you make sure to enable them by clicking the bell icon?

@Calinou Calinou added this to the 4.0 milestone Jan 31, 2022
@snailrhymer
Copy link
Contributor Author

Okay, confirmed that the toasts go off-screen in alpha 1 too.

enable them by clicking the bell icon

In alpha 1, this didn't enable them for me ( the same as #56550). It looks like the default behaviour for show_internal_errors_in_toast_notifications is Auto. In alpha 1, auto disabled them; in the custom build, it enabled them, I think due to them being official and development, respectively.

@akien-mga
Copy link
Member

In alpha 1, this didn't enable them for me ( the same as #56550). It looks like the default behaviour for show_internal_errors_in_toast_notifications is Auto. In alpha 1, auto disabled them; in the custom build, it enabled them, I think due to them being official and development, respectively.

See #56550 (comment)

@reduz
Copy link
Member

reduz commented Jan 17, 2023

@groud can you implement some EDITOR_DEF for the label maximum width?

@akien-mga
Copy link
Member

akien-mga commented Jan 17, 2023

It probably doesn't need to be a setting, just a hardcoded percentage of the available window width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants