Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast queue can't be cleared and has unexpected notification behaviour. #57488

Open
snailrhymer opened this issue Jan 31, 2022 · 4 comments
Open

Comments

@snailrhymer
Copy link
Contributor

Godot version

v4.0.alpha1.official [31a7ddb]

System information

Windows 10

Issue description

Clicking the X on a toast only clears it temporarily.

Moreover, once toasts have been hidden (either by closing them or letting them disappear), the red dot informing users of an error is hidden. If instead the user mutes the toasts, the red dot is always present.

toast_behaviour.mp4

(not shown above, but clearing the output doesn't clear the toasts)

Steps to reproduce

Get some toasts and try to remove them from the list. Click the bell icon and see them reappear.

Mute the toasts by clicking the bell icon, see the red dot persist.

Minimal reproduction project

No response

@snailrhymer
Copy link
Contributor Author

Maybe it's just the red dot while muted that's unexpected behaviour - reopening old notifications seems to be expected behaviour:

#52940 (comment)

@groud
Copy link
Member

groud commented Feb 1, 2022

Get some toasts and try to remove them from the list. Click the bell icon and see them reappear.

If I remember correctly, pressing the bell icon pops up the last errors that are still valid. After a while, the red dot disappears and you can no longer see those errors.

Mute the toasts by clicking the bell icon, see the red dot persist.

This is by design, even if the error does not appears it makes sense it tells you an error can be read if you unmute them.

All of those are by design, the "clear button" hides the notification, it does not clear them. Hiding notifications doesn't prevent the fact they are still triggered, it a less noticable manner (thus the red dot).

@groud groud added discussion and removed bug labels Feb 1, 2022
@snailrhymer
Copy link
Contributor Author

A couple of things still strike me as odd about the behaviours:

  1. In the unmuted state, the bell icon only has a red dot while popups are being displayed. Is it feasible that a user could miss a popup in the time it's displayed (e.g. if looking at something on another screen)? If so, it may be useful to have the red dot persist until manually cleared in some way.
  2. In the muted state, I would want the red dot to be able to tell me that there's a new error that needs my attention. As it is, the red dot only tells me that I've had at least one error since opening the editor.

A possible solution would be to have the red dot display whenever there are popups still in the queue (independent of whether the system is muted or unmuted), and add a button near the mute button that lets the user manually clear the queue:

image

@KoBeWi KoBeWi removed this from the 4.0 milestone May 17, 2022
@Zylann
Copy link
Contributor

Zylann commented Feb 26, 2023

Toasts are broken too for me, sometimes they also keep blinking like crazy and not clearing. Not sure how that happens, but if I open a project that contains errors in some scripts I always end up with a blinking one:

2023-02-26.20-28-43.mp4

Here is a worse occurrence I managed to capture (I had to leave Godot unfocused otherwise blinking was too fast for the capture):

2023-02-26.20-36-38.mp4

@Calinou Calinou added this to the 4.x milestone Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants