Fullscreen mode cannot be toggled off

[Chaosus]

Godot version

26facc0

System information

Windows 10

Issue description

After the editor screen entered to the fullscreen it cannot be turned back to windowed mode - it just flickers and become fullscreen again:

This problem affects a debugged project as well.

Steps to reproduce

Toggle fullscreen in the editor on the current master (26facc0). It's a recent regression - it works correctly on Alpha 1.

Minimal reproduction project

No response

[Sauermann]

On Debian 11 + Xfce, the symptoms are the same.

[bruvzg]

Seems like regression from #54645, seems like this check is not always working:

godot/platform/windows/display_server_windows.cpp

Lines 2738 to 2740 in 0154ce2

	} else if (window_client_rect.position == screen_position && window_client_rect.size == screen_size) {
	window.fullscreen = true;
	}

[bruvzg]

#57790 - fix for Windows.

On Debian 11 + Xfce, the symptoms are the same.

Should be a completely unrelated issue, was it working in alpha 1?

[Sauermann]

Should be a completely unrelated issue, was it working in alpha 1?

You are right. It was not working on Linux in alpha 1. There is already a bug report for that: #55109

[bruvzg]

Fix for Linux/X11 - #57794, #55109 is not entirely the same issue, at least part about maximized windows behavior is probably unrelated.