Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources from addons folder are not being properly imported to WebXR #59949

Closed
mgrigajtis opened this issue Apr 6, 2022 · 5 comments
Closed

Comments

@mgrigajtis
Copy link

Godot version

3.4.4

System information

Windows 11

Issue description

When creating a WebXR game, adding child instance scenes such as hand models and function like movement, teleport, and pickup do not function at all. Hand models will not be visible and functions do not fire.

Steps to reproduce

Create a new project and add hand and function child scenes from Open XR tools. Export as a HTML app and run in browser.

Minimal reproduction project

XRTools_WebXR_Test.zip

@Calinou
Copy link
Member

Calinou commented Apr 6, 2022

cc @dsnopek

@dsnopek
Copy link
Contributor

dsnopek commented Apr 7, 2022

The models not importing thing is very strange! I'll look into this as soon as I can.

function like movement, teleport, and pickup do not function at all

The functions not working, however, isn't that unexpected. The button ids are all different between OpenXR and WebXR, and so I wouldn't be surprised if some changes were necessary to XR Tools to make it fully compatible with WebXR.

@dsnopek
Copy link
Contributor

dsnopek commented Apr 7, 2022

It appears as though vertex compression doesn't work in an HTML5 export.

You can fix the models importing by:

Selection_357

  1. Select the "LeftHand.glb" in the "File System" pane
  2. Switch to the "Import" tab
  3. Uncheck "Vertex" in the "Compress" section
  4. Click the "Reimport" button
  5. Export the project to HTML5 and open in the browser!

As far as the hands not animating, I think that's issue for the XR Tools project! The Hand.gd is getting the trigger and grip from a particular axis id, which is different in WebXR:

https://github.com/GodotVR/godot-xr-tools/blob/master/addons/godot-xr-tools/assets/Hand.gd#L7

@Calinou
Copy link
Member

Calinou commented Apr 7, 2022

cc @The-O-King

@dsnopek
Copy link
Contributor

dsnopek commented Apr 11, 2022

The import settings on those model in XR Tools were fixed in GodotVR/godot-xr-tools#118 (disabling vertex compression), and the axis/button ids can be converted using the feature added in #59994 which was just merged.

So, I don't think there's anything left to do here! I'm going to close this for now, but we can re-open if anyone thinks there's more work that should be done. Thanks, Everyone! :-)

@dsnopek dsnopek closed this as completed Apr 11, 2022
@akien-mga akien-mga added this to the 3.5 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants