Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single [indent] not working properly in RichTextLabel #67026

Open
Tracked by #39144
dalexeev opened this issue Oct 7, 2022 · 3 comments
Open
Tracked by #39144

Single [indent] not working properly in RichTextLabel #67026

dalexeev opened this issue Oct 7, 2022 · 3 comments
Assignees
Milestone

Comments

@dalexeev
Copy link
Member

dalexeev commented Oct 7, 2022

Godot version

v4.0.beta.custom_build [61021c0]

System information

Kubuntu 22.04

Issue description

A single [indent] (or push_indent) is handled incorrectly (indented only after \n) if there is another open Item before it. However, if [indent] is the first one, or there are multiple [indent], then the indentation is correct.

In particular, this bug can be seen in Editor Help:

Steps to reproduce

BBCode Result Comment
[indent]123
456

Correct.
[u][indent]123
456

The bug.
[indent][u]123
456

Correct.
[u][indent][indent]123
456

If there is more than one [indent], then it is correct.
[u][indent]
123
456

000[u][indent]123
456

Is this also a bug? What should be in this case?
[u][indent][u]123
456

Minimal reproduction project

No response

@Calinou Calinou added this to the 4.0 milestone Oct 7, 2022
@Calinou
Copy link
Member

Calinou commented Oct 7, 2022

Can you reproduce this in 3.5 (which uses an entirely different RichTextLabel implementation)?

@dalexeev
Copy link
Member Author

dalexeev commented Oct 7, 2022

Can you reproduce this in 3.5 (which uses an entirely different RichTextLabel implementation)?

In 3.5, this bug is not reproduced, regardless of the order of [u] and [indent]. The penultimate case (adding a line break before [indent]) works the same as in 4.0-dev.

@bruvzg bruvzg self-assigned this Jan 10, 2023
@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Jan 12, 2023
@dalexeev
Copy link
Member Author

The bug is still reproducible in d2699dc, but in Editor Help it is no longer visible. Probably something has changed recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants