Hitting [shift] + [tab] in the code editor doesn't work in 4.0 when no text is selected

[robbertzzz]

Godot version

4.0 beta 5

System information

Windows 11

Issue description

In Godot 3.x, [shift] + [tab] will remove one tab from the start of the line even when no text is selected. In Godot 4.x, text needs to be selected for this to work. Godot's 3.x behaviour is in line with most IDEs and code editors, so reporting this as a bug.

Steps to reproduce

1. Create a script (the default script will do) and open it in the code editor.
2. Place the cursor/caret on an indented line.
3. Press [shift] + [tab].
4. Observe that nothing happens when no text is selected.

Minimal reproduction project

No response

[MewPurPur]

I'm looking into it. It has been around since alpha 1, probably longer.

Edit: I can't quite understand how the indent/unindent logic is supposed to be so I won't touch it, but here's the correct one in 3.x

https://github.com/godotengine/godot/blob/3.x/scene/gui/text_edit.cpp#L3225

and incorrect one in 4.beta

https://github.com/godotengine/godot/blob/master/scene/gui/code_edit.cpp#L898

To me it looks like unindent is always supposed to call unindent_lines(), not only when something is selected or you're at the beginning of a line. But maybe there are exceptions or something? Maybe @Paulb23 can help

EDIT: Nevermind, there is a PR for this already. And it does the same thing I would - just turning do_unindent() into unindent_lines()

[MewPurPur]

#50279 This is a duplicate apparently