Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread silently fails on Parse Error #68811

Closed
pseidemann opened this issue Nov 18, 2022 · 2 comments
Closed

Thread silently fails on Parse Error #68811

pseidemann opened this issue Nov 18, 2022 · 2 comments

Comments

@pseidemann
Copy link

Godot version

v3.5.1.stable.official [6fed1ff]

System information

macOS 12.6.1 (21G217)

Issue description

when a thread function runs via Thread.new() + start(), an error like "Parse Error" will block the thread and give no error message whatsoever.

one way to trigger this behavior is via giving callv() not an array:
self.callv("some_method", 42)
(42 should be [42])

when this code runs in the main thread, an error message is displayed. when this code runs inside another thread, the thread will block and no error message is given, leaving the user in the unknown why a thread is blocking.

I suspect this might happen with other errors as well, but I'm not sure what class of errors exist which should be tested.

Steps to reproduce

run self.callv("some_method", 42) in a thread other than the main thread

Minimal reproduction project

self.callv("some_method", 42)

@timothyqiu
Copy link
Member

Probably the same as #18330

@akien-mga
Copy link
Member

Indeed, consolidating this in #18330.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants