WorldEnvironment makes adjustments to editor dropdowns and dialogs if background mode is set to Canvas

[ItsDaBenji]

---

Bugsquad note: This issue has been confirmed several times already. No need to confirm it further.

---

Godot version

4.0-beta6

System information

Windows 10, mobile renderer

Issue description

When messing with the world environment node in 2D, I was adding some bloom effect to my game, and the editor itself now has bloom

Steps to reproduce

Create a 2D scene
Add a world environment node
Set the Background mode to "Canvas"
Enable "Glow"
Increase both the "Strength" and "Blend" values
For best results, set "Blend mode" to "Replace"
Open up any sub menu (I discovered this by clicking to change the Blend Mode again, but the project settings is also effected by the post processing)

Minimal reproduction project

2DPostProcessingErrorProject.zip

[Calinou]

Related to #52467.

[snougo]

I can reproduce issue in Godot4 beta6 on Mac

[clayjohn]

This issue is deceptively tricky and may require quite a bit of work to fix.

Primarily it comes from how we handle editor drawing.

1. The environment from the user's scene is also applied to the root Viewport (i.e. the editor itself)
2. We instruct the root Viewport to ignore the environment by setting the disable_environment flag
3. In Godot 4.x, we have popup Windows which are independent from the root (or at least, have their own Viewport)

Unfortunately, the disable_environment flag does not carry over to child Viewports so the popup windows use the environment even though they shouldn't.

I'm not sure what an ideal fix would look like. On the one hand, we can probably make child Viewports inherit the disable_environment flag from their parents, but that may not be useful and may cause its own problems.

We can't simply have the child inherit the settings of its parent as it is registered with the parent each time it is made visible. So if the child has settings of its own, they would be lost once it was made visible.

edit: One option that works, but is a total pain is to manually disable the environment for each editor popup clayjohn@a2ba315 I tested it out here. This commit fixes the issue for all of the top-level popups. But it would need to be done for every editor class to close this issue. We need to find a better way

[sandmuel]

Had same issue, came to see if it was already reported, guess this answers my question. :)

[2fd5]

Still can reproduce with Godot 4.0.beta15 on Macbook Air M1 running macOS