Vulkan: Disabling V-Sync on Intel integrated graphics crashes the renderer

[henriquelalves]

Godot version

4.0 (beta 10)

System information

Fedora, Intel(R) HD Graphics 5600 (BDW GT2)

Issue description

I'm developing a PoC for benchmarking the player's hardware and setting the graphic settings accordingly. When running it on a machine without GPU (only an Intel Integrated Graphics), the project renderer crashes on the line where the settings disable the DisplayServer VSync (Godot throws an error, and the screen stays black. The project does not close, though).

Steps to reproduce

This only happens when VSync is set "Enabled" on Project Settings and is set to disabled with DisplayServer.window_set_vsync_mode(). I can't reproduce this issue on a machine with GPU.

Minimal reproduction project

https://github.com/GDQuest/3D-graphics-benchmark-PoC

[Calinou]

Can you reproduce this after switching to the Compatibility (OpenGL) rendering backend in the project settings?

[henriquelalves]

I'll need to take a look again. I just updated my Fedora drivers after finding this Issue to use its GPU instead of Integrated Graphics, and now I can't disable it as easy as in Pop_OS.

[ahopness]

Can you reproduce this after switching to the Compatibility (OpenGL) rendering backend in the project settings?

tested on my laptop, turning of vsync on gl_compatibility works fine, this bug only happens on both Mobile and Foward+ rendering devices

the error that is printed on debugger when vsync is turned off: (last 2 lines can be ignored)

E 0:00:11:0960   scrManager.gd:151 @ apply_settings(): Condition "swapchainImageCount != sp_image_count" is true. Returning: ERR_BUG
  <C++ Source>   drivers/vulkan/vulkan_context.cpp:1967 @ _update_swap_chain()
  <Stack Trace>  scrManager.gd:151 @ apply_settings()
                 scrManager.gd:249 @ _on_chkbtn_vsync_toggled()

[Dragoncraft89]

I have the same issue with AMD Radeon Graphics (RADV RENOIR) on 4.1.1

Although the issue only seems to appear on Wayland. I cannot produce the crash on X11. @henriquelalves I think Fedora uses Wayland by default. Can you confirm?

I use sway as my window manager on wayland, in case its related.

I ran the back trace through gdb and it crashes on VulcanContext::_cleanup_swap_chain. This is nearly the same back trace as in #64766 with the only difference being that _update_swap_chain is called by set_vsync_mode instead of prepare_buffers

Therefore this is likely a duplicate of #64766

[Calinou]

Therefore this is likely a duplicate of #64766

The MRP linked in OP doesn't use multi-threaded rendering.