Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implicit conversion of the package name when exporting for Android with using "$genname" for project name starting with invalid characters. #71645

Closed
Vilcrow opened this issue Jan 18, 2023 · 2 comments · Fixed by #71646

Comments

@Vilcrow
Copy link
Contributor

Vilcrow commented Jan 18, 2023

Godot version

3.5.1.stable, v4.0.beta.custom_build [0a87ead64]

System information

Ubuntu 22.04.1

Issue description

For example, if project has name "300spartans", we can't enter the "org.godotengine.300spartans" to "Unique Name" field. We get the error "Invalid package name: A digit cannot be the first character in a package segment". But , if we enter "org.godotengine.$genname", there will be no error message. When exporting, the name will be set as "org.godotengine.spartans" without "300" in beginning, but user will not be informed about it. I think, it is not very good. It may not be worth making changes to the source code, but mention it in the documentation.

Steps to reproduce

See issue description.

Minimal reproduction project

N/A

@akien-mga akien-mga changed the title [Android] Implicit conversion of the package name when exporting for Android with using "$genname". [Android] Implicit conversion of the package name when exporting for Android with using "$genname" for project name starting with numbers. Jan 18, 2023
@akien-mga
Copy link
Member

It should be easy to add a warning if using $genname but the generated name would be invalid.

@Vilcrow
Copy link
Contributor Author

Vilcrow commented Jan 18, 2023

@akien-mga theoretically, the project name can start with other invalid characters, not just numbers.

@akien-mga akien-mga changed the title [Android] Implicit conversion of the package name when exporting for Android with using "$genname" for project name starting with numbers. [Android] Implicit conversion of the package name when exporting for Android with using "$genname" for project name starting with invalid characters. Jan 19, 2023
@akien-mga akien-mga added this to the 4.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants