Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Node Dialog: hangs for around 10s when open and using search #73204

Closed
MikeSchulze opened this issue Feb 13, 2023 · 1 comment
Closed

Comments

@MikeSchulze
Copy link

Godot version

v4.0.rc1.official [8843d9a]

System information

Windows 10, MacOS

Issue description

I provide a plugin GdUnit4 with a lot of custom class implementations, by using class_name.

e.g. GdUnitTestSuite, which is inherited by many test classes.

When I try to open the Create Node Dialog by pressing the add icon in the scene editor, the dialog hangs for about 10s.
I can see all the engine nodes and my custom nodes.
When I use the filter, it hangs again every time I enter something and makes using the dialog bad
I guess this is relates to the massive increased loading time of script classes.

I want to exclude my plugin classes from the this Dialog.
On the latest beta version is used this pice of code to remove, but it not works on RC1 anymore

plugin.gd

func _fixup_node_inspector() -> void:
	var classes := PackedStringArray([
		"GdUnitTestSuite",
		"_TestCase",
		"GdUnitInspecor",
		"GdUnitExecutor",
		"GdUnitTcpClient",
		"GdUnitTcpServer"])
	for clazz in classes:
		remove_custom_type(clazz)

func _enter_tree():
   ...
   _fixup_node_inspector()

Steps to reproduce

  • Download the latest branch (master) of GdUnit4 and activate the plugin
  • create a new scene
  • using the add node button to open the Create Node Dialog

Minimal reproduction project

N/A

@YuriSizov
Copy link
Contributor

This seems to be a duplicate of #27333, actually. So consolidating. Thanks for your report!

@YuriSizov YuriSizov closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2023
@YuriSizov YuriSizov removed this from the 4.1 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants