Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plugin dialog's validation should be changed for consistency #76681

Closed
KoBeWi opened this issue May 2, 2023 · 4 comments · Fixed by #76778
Closed

Create Plugin dialog's validation should be changed for consistency #76681

KoBeWi opened this issue May 2, 2023 · 4 comments · Fixed by #76778

Comments

@KoBeWi
Copy link
Member

KoBeWi commented May 2, 2023

Godot version

4.0

System information

Windows 10 x64

Issue description

We have an established way to inform about invalid input fields: using red/green/yellow labels at the bottom:

It's used in Create New Scene dialog, Add Metadata dialog, New Folder dialog, Create Script dialog and probably others.

Meantime the New Plugin dialog (accessible in Project Settings -> Plugins) looks like this:
image
Instead of info labels, it uses info icons that show message on hover. This dialog was created before we had an established way of validating input, so it needs updating.

Steps to reproduce

  1. Project
  2. Project Settings
  3. Plugins
  4. Create New Plugin
  5. 👀

Minimal reproduction project

N/A

@brno32
Copy link
Contributor

brno32 commented May 2, 2023

I'd be happy to take a look at this one

@eugene87222
Copy link
Contributor

eugene87222 commented May 6, 2023

Hi @brno32, would you mind letting me fix this issue😄?
I've fixed it in my fork repo.

@brno32
Copy link
Contributor

brno32 commented May 6, 2023

I do not mind! Your code looks similar to mine :)

Do we use the assignee feature here? I had already started working on it, so an official assignee might have saved the duplicated effort.

@eugene87222
Copy link
Contributor

Thanks! I think assignee is not required here.

@YeldhamDev YeldhamDev added this to the 4.1 milestone May 7, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.x Jun 23, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants