Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve/path tools (in 3D) not working with floating script editor. #78193

Closed
bt0rne opened this issue Jun 13, 2023 · 4 comments
Closed

Curve/path tools (in 3D) not working with floating script editor. #78193

bt0rne opened this issue Jun 13, 2023 · 4 comments

Comments

@bt0rne
Copy link

bt0rne commented Jun 13, 2023

Godot version

v4.1.beta1.official [828ec2c]

System information

Godot v4.1.beta1 - Debian GNU/Linux 12 (bookworm) 12 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 6GB (nvidia) - Intel(R) Core(TM) i5-7600K CPU @ 3.80GHz (4 Threads)

Issue description

I'm working on a project with a lot of curves, and i decided to test the new feature to make the script editor float. This doesn't affect much that i have seen for now, exept that using the path/curve tools does not work while the script editor is floating, for some reason.

The curve points seems to disappear when re-selecting the Path3D node after making the script editor float. The points appear again and everything works great when exiting the floating script editor and then reselecting the Path3D node again. I suppose the tools not working are an extension of the problem with the points disappearing.

I could not reproduce the issue with 2D nodes.

Simple Path3D node setup:
image
image

Before and after:
image
image

Steps to reproduce

Make points disappear:

  • Add Path3D node.
  • Add 1 or more points.
  • In the "Script" tab, press "Make Floating".
  • Reselect the Path3D node.

Make points appear again:

  • Exit the floating script window.
  • Reselct the Path3D node.

Minimal reproduction project

N/A

@OhiraKyou
Copy link

Just ran into this. I always have the script editor open in a floating window. Perhaps there's still an assumption somewhere in the code that the 3D tab will not be in use while other tabs, like Script, are in use (not taking into account the possibility of floating).

As described in the reproduction steps, you have to reselect the path node to see points appear or disappear after opening or closing the script window.

Relevant information:

  • Godot Engine version: v4.1.1.stable.official [bd6af8e0e]
  • Renderer: Compatibility
  • OS: Fedora Linux 38 (Workstation Edition)
  • Desktop environment: GNOME 44.5
  • Windowing System: X11

@Okxa
Copy link

Okxa commented Nov 6, 2023

Happens also with custom gizmos added by EditorNode3DGizmoPlugin, probably with all gizmos that add handles.

Godot version: v4.1.2.stable.arch_linux

2023-11-06.21-48-31.mp4-2mb.mp4

This might help, it is apparently cherry picked for 4.1.3: #80647

@Okxa
Copy link

Okxa commented Nov 7, 2023

Just tested this, it is fixed in v4.1.3.stable for all handles, or atleast for those that I tested: curves and my custom gizmo handles
image

@Cammymoop
Copy link
Contributor

Confirmed, fixed by #80647

@akien-mga akien-mga added this to the 4.2 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants