Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button of FileDialog keeps disabled after changing file_mode. #79210

Closed
HolonProduction opened this issue Jul 8, 2023 · 0 comments · Fixed by #79211
Closed

Save button of FileDialog keeps disabled after changing file_mode. #79210

HolonProduction opened this issue Jul 8, 2023 · 0 comments · Fixed by #79211
Milestone

Comments

@HolonProduction
Copy link
Member

Godot version

v4.1.stable.official [9704596]

System information

Windows 10

Issue description

When changing the file_mode of FileDialog from "Open File" to "Save File" via code the "Save" button keeps disabled until a file or folder is selected if the "Open" button was disabled before.

Basically the button activity has to be updated when file_mode is changed. I have made the change already but the last time I opened an PR without an issue some people requested I open one. So here you are!

Steps to reproduce

  • Open the MRP and start it
  • click anywere to open the dialog
  • after 10 seconds the dialog changes file_mode
  • if the button is disabled before the change it is as well after it

Minimal reproduction project

file_dialogue_test.zip

@dalexeev dalexeev added bug topic:gui cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 8, 2023
@dalexeev dalexeev added this to the 4.2 milestone Jul 8, 2023
@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants