FileDialog considers /path/to/dir/'s parent directory to be path/to/dir

[mieldepoche]

Godot version

4.1.1

System information

linux

Issue description

• When favoriting a path in a FileDialog, clicking on it travels to path/to/dir/.
• When going up a level from there, it doesn't go to path/to but to path/to/dir (without the /).

simplescreenrecorder-2023-08-18_09.38.37.webm

The problem is either (or both) that:

• loaded path has a trailing /
• parent dir of stuff/ is considered to be stuff

Steps to reproduce

favorite a directory and use the feature to navigate to it

Minimal reproduction project

any (i.e. the project manager's "new project" dialog has one)

[AThousandShips]

Can you confirm this on 4.1.1? Please make sure bugs are present on an up to date version

[mieldepoche]

Can you confirm this on 4.1.1

ah, missed that one. It does.

[aXu-AP]

I couldn't replicate on Windows 10, so maybe this is dependent on OS?

Edit: Can replicate on Web editor ✔

[Alex2782]

Can the function _go_up() be modified for this?

I believe get_base_dir() is working as it should be. (190 results in 80 files)
The function change_dir exists 4 times, also for Android.

godot/editor/gui/editor_file_dialog.cpp

Line 1530 in 5444afa

void EditorFileDialog::_go_up() {

to:

void EditorFileDialog::_go_up() {
	String cur_dir = get_current_dir();

	if (cur_dir.ends_with("/")) {
		cur_dir = cur_dir.substr(0, cur_dir.length() - 1);
	}

	dir_access->change_dir(cur_dir.get_base_dir());
	update_file_list();
	update_dir();
	_push_history();
}

Test on MacOS:

Screen-2023-08-20-000912.mp4